gh-107424: avoid using lambda functions in textwrap.indent() - #107426
gh-107424: avoid using lambda functions in textwrap.indent()#107426picnixz wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sorry, something went wrong.
|
Our goal is not only maximize performance. And textwrap.indent() is not performance critical for most applications as far as I know. In #107374, I made the code slightly simpler by removing generator.
Yes. It is old technique. Recent Python has little method call overhead. So append = L.append before loop has only little venefit. |
Sorry, something went wrong.
As mentioned by #107374 (comment), avoiding the use of a lambda function when no predicate is specified is expected to improve the performances.
The benchmarks reported on the issue corroborate this assumption. However, I would like to know if this is only because my laptop is dying (caching .append calls do not seem to help however).
I am waiting for changes to be verified before creating a NEWS entry (should I create it in conjunction to the already created one by @methane ?)