Run sphinx-lint on Misc/NEWS.d/next/ - #108212
Merged
hugovk merged 4 commits intoAug 21, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
serhiy-storchaka
approved these changes
Aug 21, 2023
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Although I do not see a difference in some files. Why are they marked as different?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
They were "No newline at end of file": Misc/NEWS.d/next/Library/2023-07-14-16-54-13.gh-issue-106752.BT1Yxw.rst:1: found an unbalanced inline literal markup. (unbalanced-inline-literals-delimiters) Misc/NEWS.d/next/Library/2023-07-14-16-54-13.gh-issue-106752.BT1Yxw.rst:1: default role used (hint: for inline literals, use double backticks) (default-role) Misc/NEWS.d/next/Library/2020-05-03-00-33-15.bpo-18319.faPTlx.rst:1: default role used (hint: for inline literals, use double backticks) (default-role) Misc/NEWS.d/next/Library/2020-05-03-00-33-15.bpo-18319.faPTlx.rst:2: default role used (hint: for inline literals, use double backticks) (default-role) Misc/NEWS.d/next/Core and Builtins/2023-06-24-10-34-27.gh-issue-105775.OqjoGV.rst:1: No newline at end of file. (missing-final-newline) Misc/NEWS.d/next/Library/2023-08-17-14-45-25.gh-issue-105736.NJsH7r.rst:2: default role used (hint: for inline literals, use double backticks) (default-role) Misc/NEWS.d/next/Library/2023-08-17-14-45-25.gh-issue-105736.NJsH7r.rst:3: default role used (hint: for inline literals, use double backticks) (default-role) Misc/NEWS.d/next/Core and Builtins/2023-07-04-04-50-14.gh-issue-100288.yNQ1ez.rst:3: default role used (hint: for inline literals, use double backticks) (default-role) Misc/NEWS.d/next/Library/2023-06-30-16-42-44.gh-issue-106263.tk-t93.rst:2: No newline at end of file. (missing-final-newline) Misc/NEWS.d/next/Build/2023-07-28-18-17-33.gh-issue-106881.U3Ezdq.rst:1: default role used (hint: for inline literals, use double backticks) (default-role) Misc/NEWS.d/next/Core and Builtins/2023-07-27-11-47-29.gh-issue-104432.oGHF-z.rst:2: default role used (hint: for inline literals, use double backticks) (default-role) Misc/NEWS.d/next/Library/2023-08-07-14-12-07.gh-issue-107715.238r2f.rst:1: default role used (hint: for inline literals, use double backticks) (default-role) Misc/NEWS.d/next/Library/2023-07-16-10-40-34.gh-issue-106789.NvyE3C.rst:1: role use a single backtick, double backtick found. (role-with-double-backticks) Misc/NEWS.d/next/Library/2023-07-16-10-40-34.gh-issue-106789.NvyE3C.rst:1: role use a single backtick, double backtick found. (role-with-double-backticks) Misc/NEWS.d/next/Library/2023-06-25-12-28-55.gh-issue-106075.W7tMRb.rst:1: default role used (hint: for inline literals, use double backticks) (default-role) Misc/NEWS.d/next/Core and Builtins/2023-07-27-11-18-04.gh-issue-106078.WEy2Yn.rst:1: No newline at end of file. (missing-final-newline) Misc/NEWS.d/next/Library/2023-07-22-21-57-34.gh-issue-107089.Dnget2.rst:2: No newline at end of file. (missing-final-newline) https://github.com/hugovk/cpython/actions/runs/5925848833/job/16066091943 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
The 3.12 backport will only need the first commit, I'll backport it manually. |
Sorry, something went wrong.
AlexWaygood
approved these changes
Aug 21, 2023
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good, a few optional suggestions:
Sorry, something went wrong.
Comment thread
Misc/NEWS.d/next/Library/2023-07-14-16-54-13.gh-issue-106752.BT1Yxw.rst
Outdated
Comment thread
Misc/NEWS.d/next/Library/2023-08-17-14-45-25.gh-issue-105736.NJsH7r.rst
Outdated
Comment thread
Misc/NEWS.d/next/Library/2023-08-07-14-12-07.gh-issue-107715.238r2f.rst
Outdated
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
hugovk
enabled auto-merge (squash)
August 21, 2023 12:23
Copy link
Copy Markdown
|
GH-108213 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
There's a new commit after the PR has been approved. @serhiy-storchaka, @AlexWaygood: please review the changes made to this pull request. |
Sorry, something went wrong.
Yhg1s
pushed a commit
that referenced
this pull request
Aug 21, 2023
Yhg1s
added a commit
to Yhg1s/cpython
that referenced
this pull request
Aug 21, 2023
…issue-105736.NJsH7r.rst (effectively a backport of pythonGH-108212).
Yhg1s
added a commit
that referenced
this pull request
Aug 21, 2023
Fix lint warnings in Misc/NEWS.d/next/Library/2023-08-17-14-45-25.gh-issue-105736.NJsH7r.rst (effectively a backport of GH-108212).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on from #105750.
Before that PR, we used to run sphinx-lint on Doc/ and Misc/NEWS.d/next/
After, we only ran sphinx-lint on Doc/. I think leaving out Misc/NEWS.d/next/ was an oversight on my part, let's add it back.
In the meantime, a handful of NEWS warnings had slipped through, this PR also fixes them.