FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.11] Trim trailing whitespace and test on CI (GH-104275) by hugovk · Pull Request #108215 · python/cpython · GitHub

/ cpython Public

[3.11] Trim trailing whitespace and test on CI (GH-104275) - #108215

Merged
hugovk merged 8 commits into
python:3.11from
hugovk:3.11-pre-commit
Aug 22, 2023
ConversationCommits (8)ChecksFiles changed
Merged

[3.11] Trim trailing whitespace and test on CI (GH-104275)#108215
hugovk merged 8 commits into
python:3.11from
hugovk:3.11-pre-commit

Conversation

hugovk commented Aug 21, 2023

Copy link
Copy Markdown
Member

No description provided.

hugovk requested review from a team, 1st1, asvetlov, ezio-melotti and tiran as code owners August 21, 2023 13:33
bedevere-bot mentioned this pull request Aug 21, 2023
Merged
hugovk requested review from AlexWaygood and removed request for a team, 1st1, asvetlov and tiran August 21, 2023 13:35

hugovk commented Aug 21, 2023

Copy link
Copy Markdown
Member Author

I'll follow this with a combined backport of #105750 and #108212.

I left them out of this one to keep things separate and clearer.

AlexWaygood reviewed Aug 22, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A lot of this diff is removing invisible pagebreak characters. For most of these cases, we should delete the whole line rather than just stripping the "trailing whitespace" from the line:

Comment thread Lib/email/__init__.py Outdated
Comment thread Lib/email/base64mime.py Outdated
Comment thread Lib/email/base64mime.py Outdated
Comment thread Lib/email/base64mime.py Outdated
Comment thread Lib/email/base64mime.py Outdated
Comment thread Modules/_io/bufferedio.c
Comment thread Modules/_io/bufferedio.c
Comment thread Tools/i18n/pygettext.py Outdated
Comment thread Tools/i18n/pygettext.py Outdated
Comment thread Tools/i18n/pygettext.py Outdated

AlexWaygood commented Aug 22, 2023

Copy link
Copy Markdown
Member

See #102531 for where we removed invisible pagebreak characters from the main branch. (@hugovk, is it worth seeing if that PR could just be cleanly backported to 3.11?)

hugovk commented Aug 22, 2023

Copy link
Copy Markdown
Member Author

Good idea, and it backported cleanly 🎉 #108266

This comment was marked as outdated.

Sign in to view

hugovk commented Aug 22, 2023

Copy link
Copy Markdown
Member Author

Reverted Trim trailing whitespace, will update 3.11 into here, and then see what's left to fix.

hugovk commented Aug 22, 2023

Copy link
Copy Markdown
Member Author

And autofixed via pre-commit, let's check these changes.

Apply suggestions from code review
b0f574b 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

hugovk commented Aug 22, 2023

Copy link
Copy Markdown
Member Author

And applied the two suggestions which were still available.

AlexWaygood approved these changes Aug 22, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM now, thank you!

hugovk merged commit d678ee7 into python:3.11 Aug 22, 2023
hugovk deleted the 3.11-pre-commit branch August 22, 2023 09:57

hugovk commented Aug 22, 2023

Copy link
Copy Markdown
Member Author

Thank you very much for the reviews!

hugovk mentioned this pull request Aug 22, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL