FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-33023: Fix NotImplemented to NotImplementedError. by serhiy-storchaka · Pull Request #10934 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-33023: Fix NotImplemented to NotImplementedError. - #10934

Merged
serhiy-storchaka merged 1 commit into
python:masterfrom
serhiy-storchaka:not-implemented-error
Dec 6, 2018
ConversationCommits (1)ChecksFiles changed
Merged

bpo-33023: Fix NotImplemented to NotImplementedError.#10934
serhiy-storchaka merged 1 commit into
python:masterfrom
serhiy-storchaka:not-implemented-error

Conversation

serhiy-storchaka commented Dec 5, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 skip news labels Dec 5, 2018
terryjreedy approved these changes Dec 5, 2018
View reviewed changes

terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

debugger_r fix is correct as far as it goes. Line is from cf3c421
(KBK, 2007). It is obviously is never called.

The dict_keys return from 3.x dict.keys() is still neither public, in the sense of being a built-in name, nor pickleable (a live view across processes might be nice, but ...) I will consider removing this if I have occasion to review the containing class.

serhiy-storchaka merged commit 42b1d61 into python:master Dec 6, 2018

miss-islington commented Dec 6, 2018

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

serhiy-storchaka deleted the not-implemented-error branch December 6, 2018 20:37

bedevere-bot commented Dec 6, 2018

Copy link
Copy Markdown

GH-11000 is a backport of this pull request to the 3.7 branch.

miss-islington commented Dec 6, 2018

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 42b1d6127bd8595522a78a75166ebb9fba74a6a2 3.6

miss-islington commented Dec 6, 2018

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 42b1d6127bd8595522a78a75166ebb9fba74a6a2 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 6, 2018
bpo-33023: Fix NotImplemented to NotImplementedError. (pythonGH-10934)
193d60a 
(cherry picked from commit 42b1d61)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Dec 6, 2018
[3.6] bpo-33023: Fix NotImplemented to NotImplementedError. (pythonGH…
10695c9 
…-10934).

(cherry picked from commit 42b1d61)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-bot commented Dec 6, 2018

Copy link
Copy Markdown

GH-11001 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Dec 6, 2018
bpo-33023: Fix NotImplemented to NotImplementedError. (GH-10934)
6485aa6 
(cherry picked from commit 42b1d61)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Dec 6, 2018
bpo-33023: Fix NotImplemented to NotImplementedError. (GH-10934). (GH…
7a2cf1e 
…-11001)

(cherry picked from commit 42b1d61)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Dec 6, 2018
[2.7] bpo-33023: Fix NotImplemented to NotImplementedError. (pythonGH…
f820f55 
…-10934). (pythonGH-11001)

(cherry picked from commit 42b1d61).
(cherry picked from commit 7a2cf1e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Dec 7, 2018
[2.7] bpo-33023: Fix NotImplemented to NotImplementedError. (GH-10934)…
324e179 
…. (GH-11001) (GH-11008)

(cherry picked from commit 42b1d61)
(cherry picked from commit 7a2cf1e)
serhiy-storchaka mentioned this pull request Dec 7, 2018
Closed
tiran mentioned this pull request May 28, 2019
Closed
serhiy-storchaka removed their assignment Dec 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

terryjreedy terryjreedy approved these changes

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL