Repository navigation
bpo-35429: Use raise NotImplementedError instead of NotImplemented - #10999
Closed
rth wants to merge 3 commits into
Closed
rth wants to merge 3 commits into
rth wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Please add tests to prevent regression. |
Sorry, something went wrong.
rth
commented
Dec 6, 2018
Comment thread
Lib/test/test_ssl.py
| self.assertIsInstance(remote, ssl.SSLSocket) | ||
|
|
||
| with self.assertRaises(NotImplementedError): | ||
| remote.dup() |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Maybe this is not the best place to put this check, but it's not obvious to construct the ssl.SSLSocket instance manually, and there is no other place in this test file where we are sure to have such instance.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks @rhettinger, added non regression tests.. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://bugs.python.org/issue35429
In two places in stdlib, raise NotImplemented was used instead of raise NotImplementedError. The former is not valid and produces,
>>> raise NotImplemented('message') Traceback (most recent call last): File "<stdin>", line 1, in <module> TypeError: 'NotImplementedType' object is not callablehttps://bugs.python.org/issue35429