FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.12] gh-108948: Skip test_tarfile.test_modes() on EFTYPE error (#109697) by vstinner · Pull Request #109698 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.12] gh-108948: Skip test_tarfile.test_modes() on EFTYPE error (#109697) - #109698

Merged
Yhg1s merged 1 commit into
python:3.12from
vstinner:test_tarfile_modes_312
Oct 2, 2023
ConversationCommits (1)ChecksFiles changed
Merged

[3.12] gh-108948: Skip test_tarfile.test_modes() on EFTYPE error (#109697)#109698
Yhg1s merged 1 commit into
python:3.12from
vstinner:test_tarfile_modes_312

Conversation

vstinner commented Sep 21, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error.

(cherry picked from commit 26e06ad)

pythongh-108948: Skip test_tarfile.test_modes() on EFTYPE error (pyth…
71a615d 
…on#109697)

On FreeBSD, regular users cannot set the sticky bit. Skip the test if
chmod() fails with EFTYPE error.

(cherry picked from commit 26e06ad)
bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Sep 21, 2023
vstinner added skip news and removed tests Tests in the Lib/test dir awaiting review labels Sep 21, 2023
This was referenced Sep 21, 2023
Closed
Merged

vstinner commented Sep 21, 2023

Copy link
Copy Markdown
Member Author

!buildbot AMD64 FreeBSD

bedevere-bot commented Sep 21, 2023

Copy link
Copy Markdown

The regex {builder_filter!r} did not match any buildbot builder

vstinner mentioned this pull request Sep 21, 2023
Merged

vstinner commented Sep 21, 2023

Copy link
Copy Markdown
Member Author

The regex {builder_filter!r} did not match any buildbot builder

I knew it in advance :-) It was just to test my fix python/buildmaster-config#390 :-)

vstinner commented Sep 21, 2023

Copy link
Copy Markdown
Member Author

I tested this change manually on my FreeBSD VM: it works as expected.

JelleZijlstra commented Sep 22, 2023

Copy link
Copy Markdown
Member

@vstinner seems like there's a missing f on an f-string in the previous message from Bedevere, do you know if that's already fixed or tracked?

JelleZijlstra commented Sep 22, 2023

Copy link
Copy Markdown
Member

Ah, seems like python/buildmaster-config@69e9ee1 fixed it.

vstinner commented Sep 24, 2023

Copy link
Copy Markdown
Member Author

!buildbot AMD64 FreeBSD

bedevere-bot commented Sep 24, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 71a615d 🤖

The command will test the builders whose names match following regular expression: AMD64 FreeBSD

The builders matched are:

  • AMD64 FreeBSD PR

vstinner commented Sep 24, 2023

Copy link
Copy Markdown
Member Author

AMD64 FreeBSD buildbot joined the club of STABLE buildbots and so can now used on GitHub PRs with !buildbot AMD64 FreeBSD comment!

vstinner commented Sep 25, 2023

Copy link
Copy Markdown
Member Author

buildbot/AMD64 FreeBSD PR — Build done.

Good, tests pass.

Total test files: run=479/483 skipped=16 resource_denied=4
Result: SUCCESS

Currently, FreeBSD 3.12 buildbot fails because of test_tarfile: https://buildbot.python.org/all/#/builders/1220

Yhg1s merged commit 84ef145 into python:3.12 Oct 2, 2023
vstinner deleted the test_tarfile_modes_312 branch January 14, 2025 08:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL