gh-108948: Skip test_tarfile.test_modes() on EFTYPE error by vstinner · Pull Request #109697 · python/cpython · GitHub

On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error.

Issue: tarfile doesn't set file modes correctly on FreeBSD: test_tarfile.test_modes() fails on FreeBSD #108948

On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error.

!buildbot AMD64 FreeBSD

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 7c568a4 🤖

The command will test the builders whose names match following regular expression: AMD64 FreeBSD

The builders matched are:

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

Sorry, @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 26e06ad617bb416201c769fea91cd33d544c6a1c 3.12

Sorry, @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 26e06ad617bb416201c769fea91cd33d544c6a1c 3.11

The builders matched are:

Oh, that's the bug python/buildmaster-config#390

I wrote python/buildmaster-config#400 to fix it.

By the way, the FreeBSD buildbot cannot be matched because the builder is not declared as stable yet... because test_tarfile fails :-)

…on#109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error. (cherry picked from commit 26e06ad)

GH-109698 is a backport of this pull request to the 3.12 branch.

GH-109699 is a backport of this pull request to the 3.11 branch.

Well, I tested manually my fix on my FreeBSD before merging it: it works as expected.

I wrote backports to 3.11 and 3.12 branches (I also tested them manually).

…9697) (#109699) gh-108948: Skip test_tarfile.test_modes() on EFTYPE error (#109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error. (cherry picked from commit 26e06ad)

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 LTO + PGO 3.x has failed when building commit 26e06ad.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/78/builds/5402) and take a look at the build logs.
Check if the failure is related to this commit (26e06ad) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/78/builds/5402

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line 1059, in _bootstrap_inner
    self.run()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line 996, in run
    self._target(*self._args, **self._kwargs)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_interpreters.py", line 483, in task
    interp = interpreters.create()
             ^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/support/interpreters.py", line 25, in create
    id = _interpreters.create(isolated=isolated)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: interpreter creation failed
k


Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 1354, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1325, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 929, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 1004, in exec_module
  File "<frozen importlib._bootstrap_external>", line 1100, in get_code
  File "<frozen importlib._bootstrap_external>", line 1199, in get_data
TypeError: descriptor 'close' for '_io.BufferedReader' objects doesn't apply to a '_io.FileIO' object

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian 3.x has failed when building commit 26e06ad.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/424/builds/4978) and take a look at the build logs.
Check if the failure is related to this commit (26e06ad) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/424/builds/4978

Failed tests:

test.test_concurrent_futures.test_deadlock

Failed subtests:

test_crash_during_func_exec_on_worker - test.test_concurrent_futures.test_deadlock.ProcessPoolForkserverExecutorDeadlockTest.test_crash_during_func_exec_on_worker
test_crash_during_func_exec_on_worker - test.test_concurrent_futures.test_deadlock.ProcessPoolSpawnExecutorDeadlockTest.test_crash_during_func_exec_on_worker
test_crash_during_result_pickle_on_worker - test.test_concurrent_futures.test_deadlock.ProcessPoolSpawnExecutorDeadlockTest.test_crash_during_result_pickle_on_worker
test_crash_during_result_pickle_on_worker - test.test_concurrent_futures.test_deadlock.ProcessPoolForkserverExecutorDeadlockTest.test_crash_during_result_pickle_on_worker
test_crash_at_task_unpickle - test.test_concurrent_futures.test_deadlock.ProcessPoolSpawnExecutorDeadlockTest.test_crash_at_task_unpickle

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback:
 Thread 0xf5deb440 (most recent call first):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/threading.py", line 341 in wait
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/multiprocessing/queues.py", line 231 in _feed
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/threading.py", line 996 in run
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/threading.py", line 1059 in _bootstrap_inner
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/threading.py", line 1016 in _bootstrap


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/multiprocessing/queues.py", line 250, in _feed
    send_bytes(obj)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/multiprocessing/connection.py", line 185, in send_bytes
    self._check_closed()
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/multiprocessing/connection.py", line 138, in _check_closed
    raise OSError("handle is closed")
OSError: handle is closed


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_concurrent_futures/test_deadlock.py", line 154, in test_crash_during_func_exec_on_worker
    self._check_crash(BrokenProcessPool, _crash)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_concurrent_futures/test_deadlock.py", line 132, in _check_crash
    self._fail_on_deadlock(executor)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_concurrent_futures/test_deadlock.py", line 109, in _fail_on_deadlock
    self.fail(f"Executor deadlock:\n\n{tb}")
AssertionError: Executor deadlock:


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_concurrent_futures/test_deadlock.py", line 128, in _check_crash
    res.result(timeout=self.TIMEOUT)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/concurrent/futures/_base.py", line 458, in result
    raise TimeoutError()
TimeoutError


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_concurrent_futures/test_deadlock.py", line 167, in test_crash_during_result_pickle_on_worker
    self._check_crash(BrokenProcessPool, _return_instance, CrashAtPickle)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_concurrent_futures/test_deadlock.py", line 132, in _check_crash
    self._fail_on_deadlock(executor)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_concurrent_futures/test_deadlock.py", line 109, in _fail_on_deadlock
    self.fail(f"Executor deadlock:\n\n{tb}")
AssertionError: Executor deadlock:


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_concurrent_futures/test_deadlock.py", line 150, in test_crash_at_task_unpickle
    self._check_crash(BrokenProcessPool, id, CrashAtUnpickle())
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_concurrent_futures/test_deadlock.py", line 132, in _check_crash
    self._fail_on_deadlock(executor)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_concurrent_futures/test_deadlock.py", line 109, in _fail_on_deadlock
    self.fail(f"Executor deadlock:\n\n{tb}")
AssertionError: Executor deadlock:

test.test_concurrent_futures.test_deadlock

I created #109702 for this issue.

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL7 LTO 3.x has failed when building commit 26e06ad.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/503/builds/3941) and take a look at the build logs.
Check if the failure is related to this commit (26e06ad) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/503/builds/3941

Failed tests:

test.test_multiprocessing_fork.test_misc

Failed subtests:

test_nested_startmethod - test.test_multiprocessing_fork.test_misc.TestStartMethod.test_nested_startmethod

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto/build/Lib/test/_test_multiprocessing.py", line 5475, in test_nested_startmethod
    self.assertEqual(results, [2, 1])
AssertionError: Lists differ: [1, 2] != [2, 1]

…on#109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error.

…9697) (#109698) gh-108948: Skip test_tarfile.test_modes() on EFTYPE error (#109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error. (cherry picked from commit 26e06ad)

…on#109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error.

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

Sorry, @vstinner, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 26e06ad617bb416201c769fea91cd33d544c6a1c 3.9

Sorry, @vstinner, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 26e06ad617bb416201c769fea91cd33d544c6a1c 3.10

…on#109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error.

GH-125255 is a backport of this pull request to the 3.10 branch.

…on#109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error.

GH-125576 is a backport of this pull request to the 3.9 branch.

…ystems that don't support them (GH-108368) (GH-109697) (#125255) * gh-107902: Don't test setting suid/sgid on systems that don't support them (GH-108368) * gh-108948: Skip test_tarfile.test_modes() on EFTYPE error (#109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error. --------- Co-authored-by: Victor Stinner <vstinner@python.org>

…/sticky on systems that don't support them (pythonGH-108368) (pythonGH-109697) (pythonGH-125255) * pythongh-107902: Don't test setting suid/sgid on systems that don't support them (pythonGH-108368) * pythongh-108948: Skip test_tarfile.test_modes() on EFTYPE error (pythonGH-109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error. --------- (cherry picked from commit 6bbaab8) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>

…stems that don't support them (GH-108368) (GH-109697) (#125576) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error. Co-authored-by: Victor Stinner <vstinner@python.org>

pythongh-108948 : Skip test_tarfile.test_modes() on EFTYPE error

7c568a4

On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error.

vstinner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 21, 2023

vstinner requested a review from ethanfurman as a code owner September 21, 2023 22:28

bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Sep 21, 2023

bedevere-app Bot mentioned this pull request Sep 21, 2023

tarfile doesn't set file modes correctly on FreeBSD: test_tarfile.test_modes() fails on FreeBSD #108948

Closed

vstinner mentioned this pull request Sep 21, 2023

gh-108948: tarfile should handle sticky bit in FreeBSD #108950

Closed

vstinner added the skip news label Sep 21, 2023

vstinner merged commit 26e06ad into python:main Sep 21, 2023

vstinner deleted the test_tarfile_modes branch September 21, 2023 22:59

bedevere-app Bot removed the awaiting review label Sep 21, 2023

miss-islington assigned vstinner Sep 21, 2023

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 21, 2023

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Sep 21, 2023

csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023

pythongh-108948 : Skip test_tarfile.test_modes() on EFTYPE error (pyth…

a6fc8f3

…on#109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error.

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024

pythongh-108948 : Skip test_tarfile.test_modes() on EFTYPE error (pyth…

ec87325

…on#109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error.

encukou added needs backport to 3.9 labels Oct 8, 2024

encukou pushed a commit to encukou/cpython that referenced this pull request Oct 10, 2024

pythongh-108948 : Skip test_tarfile.test_modes() on EFTYPE error (pyth…

95bfff7

…on#109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error.

encukou mentioned this pull request Oct 10, 2024

[3.10] gh-107902: gh-108948: Don't test setting suid/sgid/sticky on systems that don't support them (GH-108368) (GH-109697) #125255

Merged

bedevere-app Bot removed the needs backport to 3.10 label Oct 10, 2024

encukou pushed a commit to encukou/cpython that referenced this pull request Oct 16, 2024

pythongh-108948 : Skip test_tarfile.test_modes() on EFTYPE error (pyth…

7ab6520

…on#109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error.

encukou mentioned this pull request Oct 16, 2024

[3.9] gh-107902: gh-108948: Don't test setting suid/sgid/sticky on systems that don't support them (GH-108368) (GH-109697) #125576

Merged

bedevere-app Bot removed the needs backport to 3.9 label Oct 16, 2024

miss-islington mentioned this pull request Oct 22, 2024

[3.9] [3.10] gh-107902: gh-108948: Don't test setting suid/sgid/sticky on systems that don't support them (GH-108368) (GH-109697) (GH-125255) #125835

Closed

gh-108948: Skip test_tarfile.test_modes() on EFTYPE error by vstinner · Pull Request #109697 · python/cpython · GitHub

Repository navigation

gh-108948: Skip test_tarfile.test_modes() on EFTYPE error - #109697

gh-108948: Skip test_tarfile.test_modes() on EFTYPE error#109697vstinner merged 1 commit intopython:mainpython/cpython:mainfrom vstinner:test_tarfile_modesvstinner/cpython:test_tarfile_modesCopy head branch name to clipboard

Conversation

vstinner commented Sep 21, 2023 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner commented Sep 21, 2023

Uh oh!

bedevere-bot commented Sep 21, 2023

Uh oh!

miss-islington commented Sep 21, 2023

Uh oh!

miss-islington commented Sep 21, 2023

Uh oh!

miss-islington commented Sep 21, 2023

Uh oh!

vstinner commented Sep 21, 2023

Uh oh!

bedevere-app Bot commented Sep 21, 2023

Uh oh!

bedevere-app Bot commented Sep 21, 2023

Uh oh!

vstinner commented Sep 21, 2023

Uh oh!

bedevere-bot commented Sep 21, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Sep 22, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

vstinner commented Sep 22, 2023

Uh oh!

bedevere-bot commented Sep 22, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

miss-islington-app Bot commented Oct 8, 2024

Uh oh!

miss-islington-app Bot commented Oct 8, 2024

Uh oh!

miss-islington-app Bot commented Oct 8, 2024

Uh oh!

miss-islington-app Bot commented Oct 8, 2024

Uh oh!

bedevere-app Bot commented Oct 10, 2024

Uh oh!

bedevere-app Bot commented Oct 16, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gh-108948: Skip test_tarfile.test_modes() on EFTYPE error#109697
vstinner merged 1 commit into
python:mainfrom
vstinner:test_tarfile_modes

vstinner commented Sep 21, 2023 •
edited by bedevere-app Bot
Loading