Repository navigation
[3.10] gh-107902: gh-108948: Don't test setting suid/sgid/sticky on systems that don't support them (GH-108368) (GH-109697) - #125255
Merged
pablogsal merged 2 commits intoOct 22, 2024
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…on#109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error.
2 tasks done
Copy link
Copy Markdown
Member
Author
|
This fixes the test_tarfile test on the FreeBSD buildbots; the unrelated test_cmd_line_script failure is still there, to be fixed in #125109. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Issue for the generated files failure: #125529 |
Sorry, something went wrong.
zware
approved these changes
Oct 16, 2024
pablogsal
approved these changes
Oct 16, 2024
Copy link
Copy Markdown
|
Thanks @encukou for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 22, 2024
…/sticky on systems that don't support them (pythonGH-108368) (pythonGH-109697) (pythonGH-125255) * pythongh-107902: Don't test setting suid/sgid on systems that don't support them (pythonGH-108368) * pythongh-108948: Skip test_tarfile.test_modes() on EFTYPE error (pythonGH-109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error. --------- (cherry picked from commit 6bbaab8) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Copy Markdown
|
GH-125835 is a backport of this pull request to the 3.9 branch. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This skips tarfile's chmod-related tests on
This also adds a few directory-related tests, which were originally omitted because they failed on some platforms. Now they will be skipped on those platforms.
In 3.11+ this was done with two commits, GH-108368 & GH-109697:
(cherry-picked from 40e52c9)
(cherry-picked from 26e06ad)
One builds on the other. IMO it makes sense to backport it all, so that these tests are the same as in 3.11+.