FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-110014: Fix inconsistent struct definition in pycore_semaphore.h by colesbury · Pull Request #110030 · python/cpython · GitHub

/ cpython Public

gh-110014: Fix inconsistent struct definition in pycore_semaphore.h - #110030

Closed
colesbury wants to merge 1 commit into
python:mainfrom
colesbury:issue_110014
ConversationCommits (1)ChecksFiles changed
Closed

gh-110014: Fix inconsistent struct definition in pycore_semaphore.h#110030
colesbury wants to merge 1 commit into
python:mainfrom
colesbury:issue_110014

Conversation

colesbury commented Sep 28, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

The pycore_semaphore.h header is included by Python/lock.c and Python/parking_lot.c. The macro _POSIX_SEMAPHORES was not consistently defined across the two files (due to a missing include of <unistd.h>) leading to different struct definitions. The RHEL8 ppc64le LTO buildbot correctly warned due to this issue.

pythongh-110014: Fix inconsistent struct definition in pycore_semapho…
6e0228b 
…re.h

The pycore_semaphore.h header is included by Python/lock.c and
Python/parking_lot.c. The macro `_POSIX_SEMAPHORES` was not consistently
defined across the two files (due to a missing include of `<unistd.h>`)
leading to different struct definitions. The RHEL8 ppc64le LTO buildbot
correctly warned due to this issue.
colesbury added skip news build The build process and cross-build labels Sep 28, 2023
colesbury requested a review from vstinner September 28, 2023 14:54
bedevere-app Bot mentioned this pull request Sep 28, 2023
Closed

colesbury commented Sep 28, 2023

Copy link
Copy Markdown
Contributor Author

!buildbot ppc64le

bedevere-bot commented Sep 28, 2023

Copy link
Copy Markdown

The regex 'ppc64le' did not match any buildbot builder.Is the requested builder in the list of stable builders?

colesbury commented Sep 28, 2023

Copy link
Copy Markdown
Contributor Author

!buildbot lto

bedevere-bot commented Sep 28, 2023

Copy link
Copy Markdown

The regex 'lto' did not match any buildbot builder.Is the requested builder in the list of stable builders?

colesbury added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 28, 2023

bedevere-bot commented Sep 28, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 6e0228b 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 28, 2023

colesbury commented Sep 28, 2023

Copy link
Copy Markdown
Contributor Author
  1. I verified locally that pycore_semaphore.h now consistently defines _PySemaphore (by temporarily added #warning)
  2. https://buildbot.python.org/all/#/builders/256/builds/1238 (ppc64, lto) does not have any warnings related to pycore_semaphore.h. It's not identical to the buildbot running on the main branch, but it's the closest configuration I could find for PRs.

vstinner commented Sep 28, 2023

Copy link
Copy Markdown
Member

The regex 'ppc64le' did not match any buildbot builder.Is the requested builder in the list of stable builders?

Oh, maybe the search is case sensitive and you should use PPC64LE or PPC64LE RHEL8.

colesbury commented Sep 28, 2023

Copy link
Copy Markdown
Contributor Author

!buildbot PPC64LE

bedevere-bot commented Sep 28, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 6e0228b 🤖

The command will test the builders whose names match following regular expression: PPC64LE

The builders matched are:

  • PPC64LE Fedora Stable LTO + PGO PR
  • PPC64LE RHEL8 PR
  • PPC64LE RHEL7 Refleaks PR
  • PPC64LE RHEL7 LTO + PGO PR
  • PPC64LE RHEL8 LTO + PGO PR
  • PPC64LE Fedora Stable Clang Installed PR
  • PPC64LE Fedora Stable LTO PR
  • PPC64LE RHEL7 PR
  • PPC64LE Fedora Stable PR
  • PPC64LE Fedora Stable Refleaks PR
  • PPC64LE RHEL7 LTO PR
  • PPC64LE RHEL8 Refleaks PR
  • PPC64LE Fedora Stable Clang PR
  • PPC64LE RHEL8 LTO PR

vstinner commented Sep 28, 2023

Copy link
Copy Markdown
Member

Oh, maybe the search is case sensitive and you should use PPC64LE or PPC64LE RHEL8.

I wrote python/buildmaster-config#409 to make the search ignores the case.

I got bitten multiple times by the !buildbot command which said nothing. So I added the "The regex 'lto' did not match any buildbot builder.Is the requested builder in the list of stable builders?" message (I just added the missing space ;-)).

colesbury commented Sep 28, 2023

Copy link
Copy Markdown
Contributor Author

Thanks!

colesbury commented Sep 29, 2023

Copy link
Copy Markdown
Contributor Author

@vstinner, would you please review this when you get a chance?

vstinner requested changes Sep 30, 2023
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh wait. The problem is way wider than pycore_semaphore.h! _POSIX_THREADS and _POSIX_SEMAPHORES macros are checked in Python/pthread_thread.h, pycore_condvar.h. and pycore_pythread.h without explicitly including <unistd.h>.

I wrote a wider change to attempt to fix all cases: PR gh-110139.

vstinner commented Sep 30, 2023

Copy link
Copy Markdown
Member

I wrote a more complete fix: PR #110139. Thanks for working on fixing these warnings!

vstinner closed this Sep 30, 2023
colesbury deleted the issue_110014 branch October 4, 2023 14:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner requested changes

Assignees

No one assigned

Labels

awaiting core review build The build process and cross-build skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL