gh-110014: Fix _POSIX_THREADS and _POSIX_SEMAPHORES usage - #110139
Conversation
Sorry, something went wrong.
* pycore_pythread.h is now the central place to make sure that _POSIX_THREADS and _POSIX_SEMAPHORES macros are defined if available. * Make sure that pycore_pythread.h is included when _POSIX_THREADS and _POSIX_SEMAPHORES macros are tested. * PY_TIMEOUT_MAX is now defined as a constant, since its value depends on _POSIX_THREADS, instead of being defined as a macro. * Prevent integer overflow in the preprocessor when computing PY_TIMEOUT_MAX_VALUE on Windows: replace "0xFFFFFFFELL * 1000 < LLONG_MAX" with "0xFFFFFFFELL < LLONG_MAX / 1000". * Document the change and give hints how to fix affected code.
|
@encukou: "Oops", I have to add an exception to Tools/build/smelly.py to tolerate the new symbol PY_TIMEOUT_MAX. Before, Python only exported symbols starting with Py, _Py and __Py (macOS). Copy of my comment: # "Legacy": some old symbols are prefixed by "PY_".
EXCEPTIONS = frozenset({
'PY_TIMEOUT_MAX',
})I would prefer to prefix all public symbols with Py and only have private symbols, but at least, now we have tooling to detect when new symbols with different prefix are added ;-) |
Sorry, something went wrong.
|
Oh. I don't know if it's related or not, but I had to write PR gh-110155 to add many <unistd.h>. WASM/WASI builds were badly broken :-( |
Sorry, something went wrong.
| added = '3.2' | ||
|
|
||
| # Not mentioned in PEP 384, was implemented as a macro in Python <= 3.12 | ||
| [data.PY_TIMEOUT_MAX] |
There was a problem hiding this comment.
@vstinner Could we instead exclude this undocumented constant from the limited API?
Sorry, something went wrong.
There was a problem hiding this comment.
I checked and apparently, it's safe to remove this constant, so I created PR gh-110217 for that.
Sorry, something went wrong.
…on#110139) * pycore_pythread.h is now the central place to make sure that _POSIX_THREADS and _POSIX_SEMAPHORES macros are defined if available. * Make sure that pycore_pythread.h is included when _POSIX_THREADS and _POSIX_SEMAPHORES macros are tested. * PY_TIMEOUT_MAX is now defined as a constant, since its value depends on _POSIX_THREADS, instead of being defined as a macro. * Prevent integer overflow in the preprocessor when computing PY_TIMEOUT_MAX_VALUE on Windows: replace "0xFFFFFFFELL * 1000 < LLONG_MAX" with "0xFFFFFFFELL < LLONG_MAX / 1000". * Document the change and give hints how to fix affected code. * Add an exception for PY_TIMEOUT_MAX name to smelly.py * Add PY_TIMEOUT_MAX to the stable ABI
📚 Documentation preview 📚: https://cpython-previews--110139.org.readthedocs.build/