Repository navigation
[3.12] gh-105716: Support Background Threads in Subinterpreters Consistently (gh-109921) - #110707
Merged
ericsnowcurrently merged 7 commits intoNov 28, 2023
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
… Consistently (pythongh-109921) The existence of background threads running on a subinterpreter was preventing interpreters from getting properly destroyed, as well as impacting the ability to run the interpreter again. It also affected how we wait for non-daemon threads to finish. We add PyInterpreterState.threads.main, with some internal C-API functions. (cherry-picked from commit 1dd9dee)
This was referenced Oct 11, 2023
Yhg1s
reviewed
Nov 20, 2023
Comment thread
Modules/main.c
Yhg1s
reviewed
Nov 20, 2023
Comment thread
Include/internal/pycore_interp.h
Outdated
ericsnowcurrently
deleted the
backport-1dd9dee-subinterpreters-allow-background-threads
branch
November 28, 2023 02:01
ericsnowcurrently
added a commit
that referenced
this pull request
Nov 28, 2023
This was referenced Dec 7, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existence of background threads running on a subinterpreter was preventing interpreters from getting properly destroyed, as well as impacting the ability to run the interpreter again. It also affected how we wait for non-daemon threads to finish.
We add PyInterpreterState.threads.main, with some internal C-API functions.
(cherry-picked from commit 1dd9dee)