Repository navigation
[3.12] gh-112826: Fix the threading Module When _thread is Missing _is_main_interpreter() - #112850
Merged
Yhg1s merged 7 commits intoDec 7, 2023
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
AlexWaygood
reviewed
Dec 7, 2023
Comment thread
Doc/whatsnew/3.12.rst
Outdated
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Yhg1s
reviewed
Dec 7, 2023
Comment thread
Doc/whatsnew/3.12.rst
Outdated
Comment thread
Doc/whatsnew/3.12.rst
Outdated
Comment thread
Lib/test/test_threading.py
Outdated
Comment thread
Lib/test/test_threading.py
Outdated
Comment thread
Lib/test/test_threading.py
Outdated
hugovk
reviewed
Dec 7, 2023
Comment thread
Doc/whatsnew/3.12.rst
Outdated
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: T. Wouters <thomas@python.org>
ericsnowcurrently
added a commit
to ericsnowcurrently/cpython
that referenced
this pull request
Dec 7, 2023
Yhg1s
approved these changes
Dec 7, 2023
Yhg1s
enabled auto-merge (squash)
December 7, 2023 20:08
ericsnowcurrently
deleted the
backport-3.12-fix-112826-missing-_thread-_is_main_interpreter
branch
December 7, 2023 20:21
ericsnowcurrently
added a commit
that referenced
this pull request
Dec 7, 2023
gh-112853) As of gh-112661, the threading module expects the _thread module to have a _is_main_interpreter(), which is used in the internal threading._shutdown(). This change causes a problem for anyone that replaces the _thread module with a custom one (only if they don't provide _is_main_interpreter()). They need to be sure to add it for 3.13+, thus this PR is adding a note in "What's New". This also forward-ports the "What's New" entry from 3.12 (gh-112850). Note that we do not also forward-port the fix in that PR. The fix is there only due to a regression from 3.12.0. There is no regression in 3.13+.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…rpreter (pythongh-112853) As of pythongh-112661, the threading module expects the _thread module to have a _is_main_interpreter(), which is used in the internal threading._shutdown(). This change causes a problem for anyone that replaces the _thread module with a custom one (only if they don't provide _is_main_interpreter()). They need to be sure to add it for 3.13+, thus this PR is adding a note in "What's New". This also forward-ports the "What's New" entry from 3.12 (pythongh-112850). Note that we do not also forward-port the fix in that PR. The fix is there only due to a regression from 3.12.0. There is no regression in 3.13+.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…rpreter (pythongh-112853) As of pythongh-112661, the threading module expects the _thread module to have a _is_main_interpreter(), which is used in the internal threading._shutdown(). This change causes a problem for anyone that replaces the _thread module with a custom one (only if they don't provide _is_main_interpreter()). They need to be sure to add it for 3.13+, thus this PR is adding a note in "What's New". This also forward-ports the "What's New" entry from 3.12 (pythongh-112850). Note that we do not also forward-port the fix in that PR. The fix is there only due to a regression from 3.12.0. There is no regression in 3.13+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_thread._is_main_interpreter() was added (and aliased as threading._is_main_interpreter()) after the 3.12.0 release, in gh-110707 (a backport of gh-112661). However, that change did not accommodate cases where users replace the _thread module with a custom version that doesn't have _is_main_interpreter() defined (e.g. gevent).
This change fixes that by falling back to a dummy _is_main_interpreter() that always says "yes". That case is unlikely and the consequences of saying a subinterpreter is the main interpreter, relative to `threading._shutdown(), are almost zero.
(We are fixing this in 3.12 only because it is a regression from the already released 3.12.0. In 3.13 (main) we will only have the note in "What's New".)
📚 Documentation preview 📚: https://cpython-previews--112850.org.readthedocs.build/