Repository navigation
gh-111062: Reusable Windows build that supports free-threaded mode as the conditional CI - #111493
Merged
corona10 merged 8 commits intoOct 30, 2023
Merged
corona10 merged 8 commits into
corona10 merged 8 commits into
Conversation
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
corona10
commented
Oct 30, 2023
Comment thread
.github/workflows/reusable-build-win.yml
|
|
||
| jobs: | ||
| build_win_32: | ||
| name: 'build and test (x86)' |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
@hugovk I would like to use the name as build and test variations for macOS and Linux too.
It looks more clear when we look at the CI status bar.
But I will do it as a separate PR.
Sorry, something went wrong.
corona10
force-pushed
the
gh-111062-windows
branch
from
7ec1416 to
158dca5
Compare
October 30, 2023 13:06
Copy link
Copy Markdown
Member
Author
|
Reopen the PR for testing topic-free-threaded label. |
Sorry, something went wrong.
Co-authored-by: Donghee Na <donghee.na@python.org>
corona10
force-pushed
the
gh-111062-windows
branch
from
d68fa4d to
869a2f3
Compare
October 30, 2023 14:30
hugovk
reviewed
Oct 30, 2023
Comment thread
.github/workflows/reusable-build-win.yml
Comment thread
.github/workflows/build.yml
Outdated
Comment thread
.github/workflows/build.yml
Outdated
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Copy link
Copy Markdown
Member
|
On a doc PR, the CI failed because Windows was skipped: https://github.com/python/cpython/actions/runs/6696696148/job/18198167333?pr=111512 It's surprising that once the job is called build_windows, but later build_win_amd64 is allowed to be skipped. Is it a typo? cc @Eclips4 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Ah, #111521 was proposed to fix the job. |
Sorry, something went wrong.
FullteaR
pushed a commit
to FullteaR/cpython
that referenced
this pull request
Nov 3, 2023
…ode as the conditional CI (python#111493) * pythongh-111062 Set up free-threaded CI for windows Co-authored-by: Donghee Na <donghee.na@python.org> * Apply suggestions from code review Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> * Update * Update names * Add files * Update * Revert "Update" This reverts commit 4f17e1a. * fix --------- Co-authored-by: juanjose.tenorio <juanjose2611@gmail.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ode as the conditional CI (python#111493) * pythongh-111062 Set up free-threaded CI for windows Co-authored-by: Donghee Na <donghee.na@python.org> * Apply suggestions from code review Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> * Update * Update names * Add files * Update * Revert "Update" This reverts commit 4f17e1a. * fix --------- Co-authored-by: juanjose.tenorio <juanjose2611@gmail.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…ode as the conditional CI (python#111493) * pythongh-111062 Set up free-threaded CI for windows Co-authored-by: Donghee Na <donghee.na@python.org> * Apply suggestions from code review Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> * Update * Update names * Add files * Update * Revert "Update" This reverts commit 4f17e1a. * fix --------- Co-authored-by: juanjose.tenorio <juanjose2611@gmail.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.