FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-111062 CI: Update skip lists for resuable workflows by hugovk · Pull Request #111521 · python/cpython · GitHub

Repository navigation

gh-111062 CI: Update skip lists for resuable workflows - #111521

Merged
hugovk merged 1 commit into
python:mainfrom
hugovk:ci-update-skip-lists
Oct 31, 2023
Merged

hugovk merged 1 commit into
python:mainfrom
hugovk:ci-update-skip-lists

Conversation

hugovk commented Oct 30, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Add all the top-level jobs on the needs and allowed-skips lists, and add the build_*_free_threaded jobs on the allowed_failures list.

Rename build_win32, build_win_amd64 and build_win_arm64 to build_windows and build_windows_free_threaded in the skip/allow lists now they're in reusable workflows.

Here's a test build on my fork showing a docs-only build completing: hugovk#58

Compare #111509 which "failed" the "All required checks pass" check.

Eclips4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

hugovk commented Oct 30, 2023

Copy link
Copy Markdown
Member Author

@webknjaz How does this look?

webknjaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@hugovk this should do. Although, the pre-reusable workflow might've required less jobs, IIRC. Nevertheless, this state is probably what you want.

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

hugovk merged commit 173d13b into python:main Oct 31, 2023
hugovk deleted the ci-update-skip-lists branch October 31, 2023 05:49
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL