Repository navigation
gh-111735: Fix turtle.rst doctests when tkinter is not present - #111736
sobolevn wants to merge 2 commits into
Conversation
Sorry, something went wrong.
| return the filename of the current backgroundimage. | ||
|
|
||
| .. doctest:: | ||
| :skipif: True |
There was a problem hiding this comment.
Maybe we should just not add the .. doctest directive here, if we never want sphinx to actually run this REPL snippet as a doctest?
Sorry, something went wrong.
There was a problem hiding this comment.
If I remove this line, there will be an error locally. I don't know why, I have no idea how to debug this kind of problems.
Sorry, something went wrong.
There was a problem hiding this comment.
Oh. That's weird :(
Sorry, something went wrong.
terryjreedy
left a comment
There was a problem hiding this comment.
I appear to have left these questions/change-requests? 'pending'.
Sorry, something went wrong.
| .. testsetup:: default | ||
| :skipif: _tkinter is None | ||
|
|
||
| from turtle import * | ||
| turtle = Turtle() |
There was a problem hiding this comment.
Since the directive is only 'seen' by sphinx, doctest.testfile fails miserably on this file (326 of 337). It seems that this file was never meant to be doctested. Can one make the directive global instead of local.
If the 2 lines were given as examples of how to minimally start (>>> import, >>> turtle =) as would seem sensible, then I believe tests would run. But I understand that you are not intending to edit content.
Sorry, something went wrong.
| turtle is headed. Do not change the turtle's heading. | ||
|
|
||
| .. doctest:: | ||
| :skipif: _tkinter is None |
There was a problem hiding this comment.
Since elsewhere the directly seems to apply to multiple test without intervening text (correct?), I believe addition makes the directive on 380-1 obsolete.
Sorry, something went wrong.
|
|
||
| .. doctest:: | ||
| :skipif: _tkinter is None | ||
| :hide: |
There was a problem hiding this comment.
Does doctest really fail on blank output? Or what does :hide: do?
Sorry, something went wrong.
|
Hello from +1 year 👋 Where are we up to with this? Can we close it? |
Sorry, something went wrong.
|
Yeah, I lost context of this a long time ago. |
Sorry, something went wrong.
I had to ignore some tests completely, because they seem like asking for user interaction / resourses that are not present (like files / images / etc).