gh-109538: Catch closed loop runtime error and issue warning by dpr-0 · Pull Request #111983 · python/cpython · GitHub

Catch RuntimeError("Event loop is closed") from base_events.py line 514 then issue a warning to user

Issue: 3.11.5 regression: StreamWriter.__del__ fails if event loop is already closed #109538

All commit authors signed the Contributor License Agreement.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

…MG5ux.rst Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

Tip:

In order to keep the commit history intact, please avoid squashing or amending history and then force-pushing to the PR. Reviewers often want to look at individual commits.

https://devguide.python.org/getting-started/pull-request-lifecycle/#quick-guide

Tip:

In order to keep the commit history intact, please avoid squashing or amending history and then force-pushing to the PR. Reviewers often want to look at individual commits.

https://devguide.python.org/getting-started/pull-request-lifecycle/#quick-guide

I see, thanks for letting me know.

Sorry to be arguing.

Catching all RuntimeErrors always feels scary -- it could mark other, more serious bugs. How about only issuing the new warning if self._loop.is_closed()?

Have you confirmed that this version solves the problem in your code? How hard would it be to write a unit test to confirm that this warning is reported?

Change looks good. Thanks. Happy to merge after we have a test. This would be the file to add the test: https://github.com/python/cpython/blob/main/Lib/test/test_asyncio/test_streams.py

Thanks @dpr-0 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

Sorry, @dpr-0 and @gvanrossum, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e0f512797596282bff63260f8102592aad37cdf1 3.12

Sorry, @dpr-0 and @gvanrossum, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e0f512797596282bff63260f8102592aad37cdf1 3.11

@dpr-0 Are you interested in attempting the backports?

@dpr-0 Are you interested in attempting the backports?

Yes, any brief backport steps or I just cherry-pick and create two PRs?

I think it's just a matter of checking out the right branch (3.11 or 3.12), cherry-picking the commit from main, resolving conflicts, and submitting a PR. Repeat for the other branch. The PR title should follow certain conventions (see either the devguide or just wait for the test to fail -- I always forget what it is and I use the latter).

I don't know what caused the conflict -- if it's complicated just ping this thread with the conflict info.

If this exception is expected then why not use self.assertRaises etc?

except allows/tolerates an exception, assert requires one and will fail if it does not happen because of other improvements.

@kumaraditya303 @gvanrossum I am planning to backport this PR and issue a new PR to improve test case.

… closed loop (python#111983) Issue a ResourceWarning instead. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> (cherry picked from commit e0f5127)

GH-112141 is a backport of this pull request to the 3.11 branch.

GH-112142 is a backport of this pull request to the 3.12 branch.

…ed with closed loop (pythonGH-111983) Issue a ResourceWarning instead. (cherry picked from commit e0f5127) pythongh-109538: Avoid RuntimeError when StreamWriter is deleted with closed loop (python#111983) Issue a ResourceWarning instead. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> (cherry picked from commit e0f5127)

GH-112141 is a backport of this pull request to the 3.12 branch.

GH-112141 is a backport of this pull request to the 3.11 branch.

GH-112142 is a backport of this pull request to the 3.12 branch.

…H-111983) (#112142) * [3.12] gh-109538: Avoid RuntimeError when StreamWriter is deleted with closed loop (GH-111983) Issue a ResourceWarning instead. (cherry picked from commit e0f5127) gh-109538: Avoid RuntimeError when StreamWriter is deleted with closed loop (#111983) Issue a ResourceWarning instead. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> (cherry picked from commit e0f5127) * Fix missing warnings import

…H-111983) (#112141) Issue a ResourceWarning instead. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> (cherry picked from commit e0f5127)

… closed loop (python#111983) Issue a ResourceWarning instead. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

dpr-0 requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners November 11, 2023 16:04

bedevere-app Bot added the awaiting review label Nov 11, 2023

bedevere-app Bot mentioned this pull request Nov 11, 2023

3.11.5 regression: StreamWriter.__del__ fails if event loop is already closed #109538

Closed

Eclips4 added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Nov 11, 2023

AlexWaygood added type-bug An unexpected behavior, bug, or error topic-asyncio labels Nov 11, 2023

dpr-0 force-pushed the closed-loop-runtime-error branch 2 times, most recently from 5dd6f38 to a0dbe8b Compare November 11, 2023 17:08

hugovk reviewed Nov 11, 2023

View reviewed changes

Comment thread Misc/NEWS.d/next/Library/2023-11-11-16-42-48.gh-issue-109538.cMG5ux.rst Outdated

dpr-0 force-pushed the closed-loop-runtime-error branch from 2f72974 to 075a7fd Compare November 12, 2023 01:59

dpr-0 and others added 3 commits November 12, 2023 10:02

pythongh-109538 : Catch closed loop runtime error and issue warning

354780a

📜🤖 Added by blurb_it.

0a1c4ef

Update Misc/NEWS.d/next/Library/2023-11-11-16-42-48.gh-issue-109538.c…

7461e4e

…MG5ux.rst Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

dpr-0 force-pushed the closed-loop-runtime-error branch from 075a7fd to 7461e4e Compare November 12, 2023 02:02

gvanrossum reviewed Nov 13, 2023

View reviewed changes

use checking condition instead of try catch

54106eb

gvanrossum approved these changes Nov 14, 2023

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 14, 2023

willingc reviewed Nov 14, 2023

View reviewed changes

bedevere-app Bot removed the awaiting merge label Nov 15, 2023

miss-islington-app Bot assigned gvanrossum Nov 15, 2023

dpr-0 deleted the closed-loop-runtime-error branch November 15, 2023 01:28

kumaraditya303 reviewed Nov 15, 2023

View reviewed changes

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Nov 16, 2023

dpr-0 mentioned this pull request Nov 16, 2023

[3.12] gh-109538: Catch closed loop runtime error and issue warning (GH-111983) #112142

Merged

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 16, 2023

dpr-0 mentioned this pull request Nov 16, 2023

[3.11] gh-109538: Catch closed loop runtime error and issue warning (GH-111983) #112141

Merged

dpr-0 mentioned this pull request Nov 17, 2023

Improve test case test_loop_is_closed_resource_warnings #112186

Closed

gschaffner mentioned this pull request Jan 17, 2024

BaseSubprocessTransport.__del__ fails if the event loop is already closed, which can leak an orphan process #114177

Closed

gvanrossum mentioned this pull request Feb 19, 2024

Abandoned StreamWriter isn't reliably detected #114914

Closed

bonzini mentioned this pull request Feb 3, 2025

Feature/question: Only show the verbose output of failed tests mesonbuild/meson#13322

Closed

+                          try:
+                              self.loop.run_until_complete(inner(httpd))
+                          # This exception is caused by `self.loop.stop()` as expected.
+                          except RuntimeError:

gh-109538: Catch closed loop runtime error and issue warning by dpr-0 · Pull Request #111983 · python/cpython · GitHub

Repository navigation

gh-109538: Catch closed loop runtime error and issue warning - #111983

gh-109538: Catch closed loop runtime error and issue warning#111983gvanrossum merged 6 commits intopython:mainpython/cpython:mainfrom dpr-0:closed-loop-runtime-errordpr-0/cpython:closed-loop-runtime-errorCopy head branch name to clipboard

Conversation

dpr-0 commented Nov 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Nov 11, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-app Bot commented Nov 11, 2023

Uh oh!

bedevere-app Bot commented Nov 11, 2023

Uh oh!

Uh oh!

hugovk commented Nov 12, 2023

Uh oh!

dpr-0 commented Nov 12, 2023

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

gvanrossum Nov 13, 2023

Choose a reason for hiding this comment

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

willingc left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-app Bot commented Nov 15, 2023

Uh oh!

miss-islington-app Bot commented Nov 15, 2023

Uh oh!

miss-islington-app Bot commented Nov 15, 2023

Uh oh!

gvanrossum commented Nov 15, 2023

Uh oh!

dpr-0 commented Nov 15, 2023

Uh oh!

gvanrossum commented Nov 15, 2023

Uh oh!

kumaraditya303 Nov 15, 2023

Choose a reason for hiding this comment

Uh oh!

terryjreedy Nov 17, 2023

Choose a reason for hiding this comment

Uh oh!

dpr-0 commented Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-app Bot commented Nov 16, 2023

Uh oh!

bedevere-app Bot commented Nov 16, 2023

Uh oh!

bedevere-app Bot commented Nov 16, 2023

Uh oh!

bedevere-app Bot commented Nov 16, 2023

Uh oh!

bedevere-app Bot commented Nov 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

gh-109538: Catch closed loop runtime error and issue warning#111983
gvanrossum merged 6 commits into
python:mainfrom
dpr-0:closed-loop-runtime-error

dpr-0 commented Nov 11, 2023 •
edited
Loading

ghost commented Nov 11, 2023 •
edited by ghost
Loading

dpr-0 commented Nov 16, 2023 •
edited
Loading