Repository navigation
[3.11] gh-109538: Catch closed loop runtime error and issue warning (GH-111983) - #112141
Merged
gvanrossum merged 2 commits intoNov 20, 2023
Merged
gvanrossum merged 2 commits into
gvanrossum merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… closed loop (python#111983) Issue a ResourceWarning instead. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> (cherry picked from commit e0f5127)
This was referenced Nov 16, 2023
gvanrossum
approved these changes
Nov 16, 2023
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Yeah, looks good. I guess this backported a test for this code.
Sorry, something went wrong.
gvanrossum
approved these changes
Nov 20, 2023
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Okay let’s merge this!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue a ResourceWarning instead.
(cherry picked from commit e0f5127) gh-109538: Avoid RuntimeError when StreamWriter is deleted with closed loop (#111983)
Issue a ResourceWarning instead.
Co-authored-by: Hugo van Kemenade hugovk@users.noreply.github.com
(cherry picked from commit e0f5127)