| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
…en __getattr__ (pythonGH-113359) cherry picked from commit 04fabe2 Adjusted for 3.11, because exception printing also happens in C code. Co-authored-by: Jérome Perrin <perrinjerome@gmail.com> Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
|
This is not a trivial backport, cherry-picking the commit was not enough, there is also C code to format exceptions in 3.11 branch. The CI is OK, but I am not familiar with C programming and python C API so I might have made mistakes here. |
Sorry, something went wrong.
There was a problem hiding this comment.
We can actually do this because we know it's not NULL.
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 2c882e0 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
|
There's a refleak test failure. |
Sorry, something went wrong.
Sorry, something went wrong.
|
Thank you ! I could reproduce locally and pushed a fix. The problem was with missing decref on values returned by PyErr_Fetch ( https://docs.python.org/3.11/c-api/exceptions.html#c.PyErr_Fetch "you own a reference to each object retrieved." ) |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit a4613e2 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit d72e989 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
(cherry picked from commit 04fabe2)
Adjusted for 3.11, because exception printing also happens in C code.