FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.11] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) by perrinjerome · Pull Request #114118 · python/cpython · GitHub

/ cpython Public

[3.11] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) - #114118

Merged
iritkatriel merged 7 commits into
python:3.11from
perrinjerome:backport-04fabe2-3.11
Jan 19, 2024
Merged

[3.11] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359)#114118
iritkatriel merged 7 commits into
python:3.11from
perrinjerome:backport-04fabe2-3.11

Conversation

perrinjerome commented Jan 16, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit 04fabe2)

Adjusted for 3.11, because exception printing also happens in C code.

perrinjerome changed the title [3.11] gh-113358: Fix rendering tracebacks with exceptions with a bro… [3.11] gh-113358: Fix rendering tracebacks with exceptions with a broken getattr (GH-113359) Jan 16, 2024
perrinjerome changed the title [3.11] gh-113358: Fix rendering tracebacks with exceptions with a broken getattr (GH-113359) [3.11] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) Jan 16, 2024
perrinjerome force-pushed the backport-04fabe2-3.11 branch 4 times, most recently from acf3006 to 453b2e0 Compare January 17, 2024 01:29
…en __getattr__ (pythonGH-113359)

cherry picked from commit 04fabe2

Adjusted for 3.11, because exception printing also happens in C
code.

Co-authored-by: Jérome Perrin <perrinjerome@gmail.com>
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
perrinjerome force-pushed the backport-04fabe2-3.11 branch from 453b2e0 to 8c12e96 Compare January 17, 2024 01:31

Copy link
Copy Markdown
Contributor Author

This is not a trivial backport, cherry-picking the commit was not enough, there is also C code to format exceptions in 3.11 branch. The CI is OK, but I am not familiar with C programming and python C API so I might have made mistakes here.

perrinjerome marked this pull request as ready for review January 17, 2024 01:51
Comment thread Python/pythonrun.c Outdated
Comment thread Python/pythonrun.c
Comment thread Python/pythonrun.c

iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We can actually do this because we know it's not NULL.

Comment thread Python/pythonrun.c Outdated
Comment thread Python/pythonrun.c Outdated
iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 17, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 2c882e0 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 17, 2024
Comment thread Python/pythonrun.c

Copy link
Copy Markdown
Member

There's a refleak test failure.

Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Contributor Author

Thank you ! I could reproduce locally and pushed a fix. The problem was with missing decref on values returned by PyErr_Fetch ( https://docs.python.org/3.11/c-api/exceptions.html#c.PyErr_Fetch "you own a reference to each object retrieved." )

iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 19, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit a4613e2 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 19, 2024
Comment thread Python/pythonrun.c
Comment thread Python/pythonrun.c Outdated
Comment thread Python/pythonrun.c Outdated
Comment thread Python/pythonrun.c
iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 19, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit d72e989 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL