[3.11] gh-113358 Fix rendering tracebacks with exceptions with a broken __getattr__ : Normalize exception - #114379
Merged
iritkatriel merged 2 commits intoJan 21, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
(cherry picked from commit f0185e3) Co-authored-by: Jérome Perrin <perrinjerome@gmail.com>
perrinjerome
marked this pull request as ready for review
January 21, 2024 10:25
iritkatriel
approved these changes
Jan 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During review of #114173 we found out
that a call to PyErr_NormalizeException was missing after PyErr_Fetch.
These are changes that were missing from #114118