FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.12] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) by perrinjerome · Pull Request #114173 · python/cpython · GitHub

/ cpython Public

[3.12] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) - #114173

Merged
iritkatriel merged 2 commits into
python:3.12from
perrinjerome:backport-04fabe2-3.12
Jan 21, 2024
ConversationCommits (2)ChecksFiles changed
Merged

[3.12] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359)#114173
iritkatriel merged 2 commits into
python:3.12from
perrinjerome:backport-04fabe2-3.12

Conversation

perrinjerome commented Jan 17, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit 04fabe2)

Adjusted for 3.12, because exception printing also happens in C code.

bedevere-app Bot mentioned this pull request Jan 17, 2024
Closed
perrinjerome changed the title gh-113358: Fix rendering tracebacks with exceptions with a broken __g…etattr__ (GH-113359) gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) Jan 17, 2024
AlexWaygood changed the title gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) [3.12] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) Jan 17, 2024
bedevere-app Bot mentioned this pull request Jan 17, 2024
Merged
perrinjerome force-pushed the backport-04fabe2-3.12 branch from ed7e67b to 30964d1 Compare January 20, 2024 04:48
[3.12] pythongh-113358: Fix rendering tracebacks with exceptions with…
3588252 
… a broken __getattr__ (pythonGH-113359)

(cherry picked from commit 04fabe2)

Co-authored-by: Jérome Perrin <perrinjerome@gmail.com>
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
perrinjerome force-pushed the backport-04fabe2-3.12 branch from 30964d1 to 3588252 Compare January 20, 2024 05:14
perrinjerome marked this pull request as ready for review January 20, 2024 05:35

perrinjerome commented Jan 20, 2024

Copy link
Copy Markdown
Contributor Author

@iritkatriel this is for 3.12 ,is it better to use PyErr_GetRaisedException as mentionned on
https://github.com/python/cpython/pull/114118/files#r1455635968 or to keep the same code as for 3.11 ? This version uses the same code as 3.11

iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 20, 2024

bedevere-bot commented Jan 20, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 3588252 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 20, 2024

iritkatriel commented Jan 20, 2024

Copy link
Copy Markdown
Member

@iritkatriel this is for 3.12 ,is it better to use PyErr_GetRaisedException as mentionned on https://github.com/python/cpython/pull/114118/files#r1455635968 or to keep the same code as for 3.11 ? This version uses the same code as 3.11

We can leave it the same. Thanks.

iritkatriel reviewed Jan 20, 2024
View reviewed changes
Comment thread Python/pythonrun.c
perrinjerome mentioned this pull request Jan 21, 2024
Merged
iritkatriel merged commit 00e8c9c into python:3.12 Jan 21, 2024
Eclips4 mentioned this pull request Jan 21, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

iritkatriel iritkatriel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL