gh-108562: fix compiler warnings for bundled libmpdec in the main - #114751
Merged
erlend-aasland merged 1 commit intoMar 3, 2024
Merged
gh-108562: fix compiler warnings for bundled libmpdec in the main#114751erlend-aasland merged 1 commit into
erlend-aasland merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This comment was marked as outdated.
This patch enable (if awailable) -fstrict-overflow for libmpdec and also shut off false positive warnings (-Warray-bounds). The later part was backported from mpdecimal-4.0.0.
skirpichev
force-pushed
the
enable-strict-overflow-108562
branch
from
3303b02 to
8e514c5
Compare
January 30, 2024 13:44
skirpichev
marked this pull request as ready for review
January 30, 2024 13:46
skirpichev
requested review from
corona10,
erlend-aasland,
rhettinger and
sethmlarson
as code owners
January 30, 2024 13:46
erlend-aasland
approved these changes
Jan 30, 2024
sethmlarson
approved these changes
Jan 30, 2024
sethmlarson
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for updating the SBOM!
Sorry, something went wrong.
erlend-aasland
approved these changes
Jan 30, 2024
rhettinger
removed their request for review
January 30, 2024 23:11
Copy link
Copy Markdown
Member
Author
|
@erlend-aasland, is this still waiting for review? Maybe I should ask Stefan (However, I think the decimal-related part was actually discussed in the issue)? |
Sorry, something went wrong.
erlend-aasland
approved these changes
Mar 3, 2024
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
If awailable, enable -fstrict-overflow for libmpdec. Also shut off false positive warnings (-Warray-bounds). The later was backported from mpdecimal-4.0.0.
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
If awailable, enable -fstrict-overflow for libmpdec. Also shut off false positive warnings (-Warray-bounds). The later was backported from mpdecimal-4.0.0.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
If awailable, enable -fstrict-overflow for libmpdec. Also shut off false positive warnings (-Warray-bounds). The later was backported from mpdecimal-4.0.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch enable (if awailable) -fstrict-overflow for libmpdec and also shut off false positive warnings (-Warray-bounds). The later part was backported from mpdecimal-4.0.0.