gh-108562: Revert enabling -fstrict-overflow for libmpdec - #116302
Merged
encukou merged 1 commit intoMar 4, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Reverts -fstrict-overflow for libmpdec
This comment was marked as outdated.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit ca35e50 🤖 The command will test the builders whose names match following regular expression: .*LTO.* The builders matched are:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
(The posix.sched_setaffinity(0, []) on CentOS9 is unrelated, not a CPython issue.) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Is this ready to be merged? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Yes. Thank you @skirpichev for the quick fix! |
Sorry, something went wrong.
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…onGH-116302) pythongh-108562: partial reversion of pr114751 Reverts -fstrict-overflow for libmpdec
Copy link
Copy Markdown
Member
Author
|
Thanks. Sorry for a breakage. Next time I will suggest running more extended tests. |
Sorry, something went wrong.
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…onGH-116302) pythongh-108562: partial reversion of pr114751 Reverts -fstrict-overflow for libmpdec
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…onGH-116302) pythongh-108562: partial reversion of pr114751 Reverts -fstrict-overflow for libmpdec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts -fstrict-overflow for libmpdec, added in #114751.