FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-115765: Don't use deprecated AC_EGREP_* macros in configure.ac by erlend-aasland · Pull Request #115791 · python/cpython · GitHub

/ cpython Public

gh-115765: Don't use deprecated AC_EGREP_* macros in configure.ac - #115791

Closed
erlend-aasland wants to merge 10 commits into
python:mainfrom
erlend-aasland:ac/2.72-egrep-source
Closed

gh-115765: Don't use deprecated AC_EGREP_* macros in configure.ac#115791
erlend-aasland wants to merge 10 commits into
python:mainfrom
erlend-aasland:ac/2.72-egrep-source

Conversation

erlend-aasland commented Feb 21, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor Author

@mhsmith, would you like to review this?

Copy link
Copy Markdown
Contributor Author

@corona10, feel free to take a look at this, if you have the time.

Comment thread configure.ac Outdated
Comment thread configure.ac Outdated

Copy link
Copy Markdown
Contributor Author

@mhsmith, thanks for the review; I addressed your remarks in 9c3596d. PTAL.

Comment thread pyconfig.h.in
Comment thread configure Outdated

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor Author

Found the culprit; typo on my end! ✅

Copy link
Copy Markdown
Contributor Author

Now, there's one more thing we should add before landing this: support configure cache.

Copy link
Copy Markdown
Contributor Author

Now, there's one more thing we should add before landing this: support configure cache.

I'm not sure we want to automatically generate the cache variable name in this macro. The first argument would need heavy string modifications to end up as a usable identifier. Perhaps it is best to introduce a new param for the cache variable name.

mhsmith commented Feb 23, 2024

Copy link
Copy Markdown
Member

Alternatively, all but one usage of PY_CHECK_CPP could be replaced with AX_CHECK_DEFINE, which has caching already built in.

erlend-aasland commented Feb 27, 2024
edited
Loading

Copy link
Copy Markdown
Contributor Author

Alternatively, all but one usage of PY_CHECK_CPP could be replaced with AX_CHECK_DEFINE, which has caching already built in.

That's a good suggestion; I'll have a look in a day or two.

UPDATE: Created alternative PR gh-116016.

Copy link
Copy Markdown
Contributor Author

Alternatively, all but one usage of PY_CHECK_CPP could be replaced with AX_CHECK_DEFINE, which has caching already built in.

For the glibc check; do we really need to worry about glibc < 2.1?

mhsmith commented Feb 28, 2024

Copy link
Copy Markdown
Member

I agree, so #116016 looks like the way to go.

Copy link
Copy Markdown
Contributor Author

Superseded by #116016

erlend-aasland deleted the ac/2.72-egrep-source branch February 28, 2024 13:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL