gh-115765: Use AX_CHECK_DEFINE instead of AC_EGREP_* - #116016
Merged
erlend-aasland merged 1 commit intoFeb 28, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
2 tasks
erlend-aasland
force-pushed
the
ac/2.72-egrep-source-alt
branch
from
f7fae08 to
9b5bdc7
Compare
February 28, 2024 00:03
erlend-aasland
marked this pull request as ready for review
February 28, 2024 12:48
erlend-aasland
commented
Feb 28, 2024
Comment thread
configure.ac
| dnl http://www.v6.linux.or.jp/ | ||
| AC_EGREP_CPP([yes], [ | ||
| #include <features.h> | ||
| #if defined(__GLIBC__) && ((__GLIBC__ == 2 && __GLIBC_MINOR__ >= 1) || (__GLIBC__ > 2)) |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Glibc 2.1 was released in February 1999. According to DistroWatch, we can safely assume that we run on glibc 2.1 or newer. All we need here is to check for __GLIBC__, AFAICS.
Sorry, something went wrong.
mhsmith
approved these changes
Feb 28, 2024
corona10
approved these changes
Feb 28, 2024
corona10
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm!
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the review, both of you! Highly appreciated :) |
Sorry, something went wrong.
Closed
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…ac (python#116016) Rewrite using AX_CHECK_DEFINE and AC_CHECK_TYPES.
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…ac (python#116016) Rewrite using AX_CHECK_DEFINE and AC_CHECK_TYPES.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…ac (python#116016) Rewrite using AX_CHECK_DEFINE and AC_CHECK_TYPES.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #115791