FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-116380: Add tests for `glob.glob0()` and `glob.glob1()`. by barneygale · Pull Request #117305 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

GH-116380: Add tests for glob.glob0() and glob.glob1(). - #117305

Closed
barneygale wants to merge 1 commit into
python:mainfrom
barneygale:gh-116380-glob0-glob1-tests
ConversationCommits (1)ChecksFiles changed
Closed

GH-116380: Add tests for glob.glob0() and glob.glob1().#117305
barneygale wants to merge 1 commit into
python:mainfrom
barneygale:gh-116380-glob0-glob1-tests

Conversation

barneygale commented Mar 27, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

These undocumented functions expand a single literal or (non-recursive) wildcard segment.

pythonGH-116380: Add tests for glob.glob0() and glob.glob1().
3ceffa8 
These undocumented functions expand a single literal or (non-recursive)
wildcard segment.
barneygale added tests Tests in the Lib/test dir skip news labels Mar 27, 2024
bedevere-app Bot mentioned this pull request Mar 27, 2024
Open

serhiy-storchaka commented Mar 28, 2024

Copy link
Copy Markdown
Member

They are undocumented and no longer used in the stdlib. glob.escape() and the root_dir parameter make them obsolete.

barneygale commented Mar 28, 2024

Copy link
Copy Markdown
Contributor Author

Indeed. But they're used by third-party code, and neither deprecated nor underscore-prefixed.

serhiy-storchaka commented Mar 28, 2024

Copy link
Copy Markdown
Member

They are not underscored because this is not needed.

Opened #117337.

barneygale commented Mar 28, 2024

Copy link
Copy Markdown
Contributor Author

Does deprecating these functions preclude the addition of tests in your view?

serhiy-storchaka commented Mar 28, 2024

Copy link
Copy Markdown
Member

The new tests LGTM. Some tests will be needed for deprecation anyway. But all tests added in this PR will be changed, and maybe moved to other place. This will only increase the size of the logs.

Would you mind creating a PR to deprecate these functions, along with adding new tests? Or do you prefer merging this PR first?

barneygale commented Mar 29, 2024

Copy link
Copy Markdown
Contributor Author

Good shout. I've opened #117371 to deprecate the functions, and incorporated the tests there. I'll close this PR!

barneygale closed this Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting core review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL