Given #116392 reduced system calls by changing design, would it be possible to add a test so that it doesn't accidentally revert? Tests are editable if a better / faster set of system calls is found, helps ensure changes are intentional. I improved the infrastructure to make this sort of testing possible a bit ago, happy to help implement:
Activity
pythonGH-116380: Make `glob.glob()` twice as fast
Merge branch 'main' into pythongh-116380
Merge branch 'main' into pythongh-116380
Merge branch 'main' into pythongh-116380
Merge branch 'main' into pythongh-116380
pythonGH-116380: Add tests for `glob.glob0()` and `glob.glob1()`.
Merge branch 'main' into pythongh-116380
Merge branch 'main' into pythongh-116380
pythonGH-117586: Speed up `pathlib.Path.glob()` by working with strings
GH-117586: Speed up `pathlib.Path.glob()` by working with strings (#1…
pythonGH-116380: Support `dir_fd` argument in `glob._Globber`.
pythonGH-116380: Support `include_hidden` argument in `glob._Globber`.
37 remaining items
Merge branch 'main' into pythongh-116380
Merge branch 'main' into pythongh-116380
Merge branch 'main' into pythongh-116380
GH-116380: Speed up `glob.[i]glob()` by making fewer system calls. (#…
cmaloney commented on Feb 28, 2025
Given #116392 reduced system calls by changing design, would it be possible to add a test so that it doesn't accidentally revert? Tests are editable if a better / faster set of system calls is found, helps ensure changes are intentional. I improved the infrastructure to make this sort of testing possible a bit ago, happy to help implement:
system call checking infrastructure: https://github.com/python/cpython/blob/main/Lib/test/support/strace_helper.py
sample test: https://github.com/python/cpython/blob/main/Lib/test/test_fileio.py#L365-L498
pythonGH-116380: Revert addition of `test_iglob_iter_close` test
Revert "pythonGH-116380: Speed up `glob.[i]glob()` by making fewer sy…
Revert "GH-116380: Speed up `glob.[i]glob()` by making fewer system c…
pythonGH-116380: Speed up `glob.[i]glob()` by making fewer system cal…
Merge branch 'main' into pythongh-116380-again
Merge branch 'main' into pythongh-116380-again