Repository navigation
GH-116380: Move pathlib-specific code from glob to pathlib._abc. - #120011
Merged
barneygale merged 3 commits intoJun 7, 2024
Merged
barneygale merged 3 commits into
barneygale merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…abc`. In `glob._Globber`, move pathlib-specific methods to `pathlib._abc.Globber` and replace them with abstract methods. Rename `glob._Globber` to `glob._GlobberBase`, and `glob._StringGlobber` to `glob._Globber`. As a result, the `glob` module is no longer befouled by code that can only ever apply to pathlib. No change of behaviour.
Copy link
Copy Markdown
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @barneygale, I could not cleanly backport this to 3.13 due to a conflict. cherry_picker 242c7498e5a889b47847fb6f0f133ce461fa7e24 3.13 |
Sorry, something went wrong.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…abc`. (python#120011) In `glob._Globber`, move pathlib-specific methods to `pathlib._abc.PathGlobber` and replace them with abstract methods. Rename `glob._Globber` to `glob._GlobberBase`. As a result, the `glob` module is no longer befouled by code that can only ever apply to pathlib. No change of behaviour.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…abc`. (python#120011) In `glob._Globber`, move pathlib-specific methods to `pathlib._abc.PathGlobber` and replace them with abstract methods. Rename `glob._Globber` to `glob._GlobberBase`. As a result, the `glob` module is no longer befouled by code that can only ever apply to pathlib. No change of behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Assignees
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In glob._Globber, move pathlib-specific methods to pathlib._abc.Globber and replace them with abstract methods. Rename glob._Globber to glob._GlobberBase, and glob._StringGlobber to glob._Globber. As a result, the glob module is no longer befouled by code that can only ever apply to pathlib.
No change of behaviour.