FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-117431: Improve performance of startswith, endswith, count and find methods for strings and bytes by eendebakpt · Pull Request #117432 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-117431: Improve performance of startswith, endswith, count and find methods for strings and bytes - #117432

Closed
eendebakpt wants to merge 3 commits into
python:mainfrom
eendebakpt:parse_args_finds
ConversationCommits (3)ChecksFiles changed
Closed

gh-117431: Improve performance of startswith, endswith, count and find methods for strings and bytes#117432
eendebakpt wants to merge 3 commits into
python:mainfrom
eendebakpt:parse_args_finds

Conversation

eendebakpt commented Apr 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Benchmarks (non-PGO):

main: python -m timeit -s "s = 'abcdef'" "s.startswith('abc')"
5000000 loops, best of 5: 63.8 nsec per loop

pr: python -m timeit -s "s = 'abcdef'" "s.startswith('abc')"
5000000 loops, best of 5: 42.3 nsec per loop

main: python -m timeit -s "s = 'abcdef'" "s.count('a')"
5000000 loops, best of 5: 70 nsec per loop

pr: python -m timeit -s "s = 'abcdef'" "s.count('a')"
5000000 loops, best of 5: 51.4 nsec per loop

main: python -m timeit -s "s = b'abcdef'" "s.startswith(b'q')"
5000000 loops, best of 5: 68.3 nsec per loop

pr: python -m timeit -s "s = b'abcdef'" "s.startswith(b'q')"
5000000 loops, best of 5: 44.5 nsec per loop

Notes:

  • We could also add a fast path for the case where there are 2 or 3 arguments. Since all arguments are positional only, for 1, 2 or 3 arguments the parsing cannot fail. That will increase performance for the 2 and 3 argument case, but it adds some more complexity.

bedevere-app Bot mentioned this pull request Apr 1, 2024
Open
eendebakpt marked this pull request as draft April 1, 2024 20:19
eendebakpt changed the title Draft: gh-117431 Improve performance of startswith, endswith, count and find methods for strings and bytes gh-117431 Improve performance of startswith, endswith, count and find methods for strings and bytes Apr 1, 2024
eendebakpt marked this pull request as ready for review April 1, 2024 21:16
AlexWaygood added the performance Performance or resource usage label Apr 1, 2024
AlexWaygood requested a review from gvanrossum April 2, 2024 14:38
erlend-aasland changed the title gh-117431 Improve performance of startswith, endswith, count and find methods for strings and bytes gh-117431: Improve performance of startswith, endswith, count and find methods for strings and bytes Apr 2, 2024

eendebakpt commented Apr 2, 2024

Copy link
Copy Markdown
Contributor Author

Closing in favor of #117466

eendebakpt closed this Apr 2, 2024
eendebakpt deleted the parse_args_finds branch June 26, 2025 13:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

awaiting review performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL