Repository navigation
gh-117431: Adapt str.{start,end}swith to use the METH_FASTCALL calling convention - #117466
Merged
erlend-aasland merged 6 commits intoApr 3, 2024
Merged
erlend-aasland merged 6 commits into
erlend-aasland merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
erlend-aasland
marked this pull request as ready for review
April 2, 2024 15:37
Copy link
Copy Markdown
Contributor
Author
# main
$ ./python.exe -m timeit -s "s = 'abcdef'" "s.startswith('abc')"
5000000 loops, best of 5: 89.1 nsec per loop
# this PR
$ ./python.exe -m timeit -s "s = 'abcdef'" "s.startswith('abc')"
10000000 loops, best of 5: 26.4 nsec per loop
|
Sorry, something went wrong.
eendebakpt
reviewed
Apr 2, 2024
Comment thread
Objects/clinic/unicodeobject.c.h
Copy link
Copy Markdown
Contributor
Author
|
We'll also want to convert str.find and friend and finally get rid of the parsing helper in strlib. However, that is best left to a follow-up PR (#117468). I prefer small and incremental changes. |
Sorry, something went wrong.
Comment thread
Objects/unicodeobject.c
Outdated
JelleZijlstra
approved these changes
Apr 2, 2024
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the review, @JelleZijlstra and @eendebakpt. I'll hold off merging for a day or two. |
Sorry, something went wrong.
methane
approved these changes
Apr 3, 2024
Copy link
Copy Markdown
Contributor
Author
|
Well, with two core devs approving, I'll go ahead and merge. Thanks for the reviews. |
Sorry, something went wrong.
methane
reviewed
Apr 3, 2024
Comment thread
Objects/unicodeobject.c
Copy link
Copy Markdown
Member
|
Nice optimization! |
Sorry, something went wrong.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…inic (python#117466) This change gives a significant speedup, as the METH_FASTCALL calling convention is now used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.