Repository navigation
gh-117431: Adapt str.find and friends to use the METH_FASTCALL calling convention - #117468
Merged
erlend-aasland merged 20 commits intoApr 3, 2024
Merged
erlend-aasland merged 20 commits into
erlend-aasland merged 20 commits into
Conversation
Eclips4
reviewed
Apr 2, 2024
erlend-aasland
marked this pull request as ready for review
April 3, 2024 07:15
Copy link
Copy Markdown
Contributor
Author
|
Similar speedsups as with str.startswith and str.endswith: # main
$ ./python.exe -m timeit -s "s = 'abcdef'" "s.count('a')"
5000000 loops, best of 5: 92.5 nsec per loop
# This PR
$ ./python.exe -m timeit -s "s = 'abcdef'" "s.count('a')"
10000000 loops, best of 5: 26.2 nsec per loop |
Sorry, something went wrong.
methane
approved these changes
Apr 3, 2024
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the review, Inada-san. |
Sorry, something went wrong.
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this pull request
Apr 6, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…n#117468) This change gives a significant speedup, as the METH_FASTCALL calling convention is now used. The following methods are adapted: - str.count - str.find - str.index - str.rfind - str.rindex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.