gh-117692: Fix AttributeError in DocTestFinder on wrapped builtin_or_method - #117699
Merged
AlexWaygood merged 2 commits intoApr 10, 2024
Merged
gh-117692: Fix AttributeError in DocTestFinder on wrapped builtin_or_method#117699AlexWaygood merged 2 commits into
AlexWaygood merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…builtin_or_method`
AlexWaygood
approved these changes
Apr 10, 2024
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice, thank you!
Sorry, something went wrong.
Comment thread
Lib/doctest.py
Outdated
Copy link
Copy Markdown
Member
|
@pablogsal -- the PR that caused the regression here was unfortunately backported to 3.11. But I assume we can't backport this fix that far, given that 3.11 is now in security-only mode? |
Sorry, something went wrong.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Copy Markdown
|
Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 10, 2024
…builtin_or_method` (pythonGH-117699) (cherry picked from commit 4bb7d12) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Copy Markdown
|
GH-117708 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…builtin_or_method` (python#117699) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #115440
CC @brianschubert @lpsinger