[3.12] gh-117692: Fix AttributeError in DocTestFinder on wrapped builtin_or_method (GH-117699) - #117708
Merged
AlexWaygood merged 3 commits intoApr 10, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…builtin_or_method` (pythonGH-117699) (cherry picked from commit 4bb7d12) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Copy Markdown
Member
|
Hmm, looks like the @doctest_skip_if decorator doesn't exist on Python 3.12 |
Sorry, something went wrong.
AlexWaygood
disabled auto-merge
April 10, 2024 10:31
Copy link
Copy Markdown
Member
@sobolevn, reckon we should just backport the doctest_skip_if decorator to 3.12 as part of this PR? It seems pretty simple and low-risk |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
See #116758 (comment) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 4bb7d12)
Co-authored-by: Nikita Sobolev mail@sobolevn.me
Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com