Repository navigation
gh-96398: Detect emcc and mpicc in compiler names in configure - #117819
Merged
erlend-aasland merged 1 commit intoApr 12, 2024
Merged
erlend-aasland merged 1 commit into
erlend-aasland merged 1 commit into
Conversation
erlend-aasland
force-pushed
the
autoconf/cc-name-emscripten-mpicc
branch
from
5e0ab50 to
6a6f585
Compare
April 12, 2024 13:27
corona10
approved these changes
Apr 12, 2024
corona10
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm!
Sorry, something went wrong.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…ython#117819) - emcc defines __EMSCRIPTEN__ - mpicc doesn't define anything in particular; detect it using basename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.