gh-117891: handle undefined TARGET_OS_OSX - #117892
Closed
jmroot wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This macro is not defined by older macOS SDKs, and the code previously didn't distinguish between it being undefined and being defined to 0.
freakboy3742
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This functionally looks fine; however, as I mentioned on my review of #117887, there's another 2 related uses of TARGET_OS symbols that need to be cleaned up; I'm not sure it's better to tackle all of them in one PR, rather than multiple PRs fixing one each.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I've commented on this here #117887 (comment) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks again for the issue and PR. The suggested change has been rolled up and merged in PR #118073. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This macro is not defined by older macOS SDKs, and the code in Modules/_testexternalinspection.c previously didn't distinguish between it being undefined and being defined to 0.