gh-114099: Modify preprocessor symbol usage to support older macOS SDKs - #118073
Merged
ned-deily merged 2 commits intoApr 19, 2024
Merged
gh-114099: Modify preprocessor symbol usage to support older macOS SDKs#118073ned-deily merged 2 commits into
ned-deily merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ned-deily
approved these changes
Apr 19, 2024
This was referenced Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older macOS SDKs don't expose the TARGET_OS_* symbols; this PR makes the preprocessor usage compatible with those older SDKs.
As discussed on PR #117887, this consolidates the two separate PRs (#117887 and #117892, both submitted by @jmroot) with an additional change to Python/marshal.c, and tags the fix against the iOS feature that introduced the issue.
Fixes #117891
Fixes #117886