FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-116622: Redirect stdout and stderr to system log when embedded in an Android app by mhsmith · Pull Request #118063 · python/cpython · GitHub

/ cpython Public

gh-116622: Redirect stdout and stderr to system log when embedded in an Android app - #118063

Merged
vstinner merged 19 commits into
python:mainfrom
mhsmith:android-log
Apr 30, 2024
ConversationCommits (19)ChecksFiles changed
Merged

gh-116622: Redirect stdout and stderr to system log when embedded in an Android app#118063
vstinner merged 19 commits into
python:mainfrom
mhsmith:android-log

Conversation

mhsmith commented Apr 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

When embedded in an app on current versions of Android, there's no easy way to monitor the process's stdout and stderr. So, as specified in PEP 738, this PR redirects them to the system log, which can be viewed using the developer tools.

bedevere-app Bot mentioned this pull request Apr 18, 2024
Closed

mhsmith commented Apr 22, 2024

Copy link
Copy Markdown
Member Author

@serhiy-storchaka: This PR is connected to the io module, which I see you've been working on recently. Are you able to review it?

encukou reviewed Apr 23, 2024
View reviewed changes
Comment thread Lib/_android_support.py
Comment thread Lib/_android_support.py Outdated
Comment thread Lib/_android_support.py Outdated
serhiy-storchaka reviewed Apr 24, 2024
View reviewed changes
Comment thread Lib/_android_support.py Outdated
Comment thread Lib/_android_support.py
Comment thread Lib/_android_support.py Outdated
Comment thread Python/pylifecycle.c Outdated
Comment thread Python/pylifecycle.c
Comment thread Python/pylifecycle.c Outdated
Comment thread Python/pylifecycle.c Outdated
Comment thread Python/pylifecycle.c
Comment thread Lib/_android_support.py
Comment thread configure.ac Outdated
encukou reviewed Apr 25, 2024
View reviewed changes

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!
This looks good to me, modulo a few small nitpicks. I'll let @serhiy-storchaka resolve the conversations he started.

Comment thread Lib/_android_support.py
Comment thread Lib/test/test_android.py Outdated
Comment thread Lib/test/test_android.py Outdated
serhiy-storchaka reviewed Apr 25, 2024
View reviewed changes
Comment thread Lib/_android_support.py
Comment thread Lib/_android_support.py Outdated
Comment thread Lib/_android_support.py Outdated
Comment thread Lib/_android_support.py
Comment thread Lib/_android_support.py Outdated
Comment thread Python/pylifecycle.c
Comment thread Lib/test/test_android.py
Comment thread Lib/test/test_android.py
Comment thread Lib/test/test_android.py
serhiy-storchaka reviewed Apr 29, 2024
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for addressing my comments. LGTM in general. I left several minor suggestions, but they are not mandatory, you can implement or reject them on case by case base.

In any case I'm going to merge this PR after your answer.

Comment thread Lib/_android_support.py Outdated
Comment thread Lib/test/test_android.py Outdated
Comment thread Lib/test/test_android.py Outdated
encukou approved these changes Apr 29, 2024
View reviewed changes

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Using the tooling and instructions in #117878, I've confirmed that this works for the test suite:

erlend-aasland removed their request for review April 30, 2024 07:34
vstinner reviewed Apr 30, 2024
View reviewed changes
Comment thread Python/pylifecycle.c
Comment thread configure.ac Outdated
mhsmith and others added 2 commits April 30, 2024 12:54
Update configure.ac
53ba406 
Co-authored-by: Victor Stinner <vstinner@python.org>
Autoreconf
5874687
vstinner merged commit 3b268f4 into python:main Apr 30, 2024

vstinner commented Apr 30, 2024

Copy link
Copy Markdown
Member

Merged. Let's see how it goes. It can be adjusted later if needed.

Nice change @mhsmith.

mhsmith mentioned this pull request Aug 5, 2024
Merged
freakboy3742 mentioned this pull request Nov 14, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments
serhiy-storchaka serhiy-storchaka approved these changes
erlend-aasland erlend-aasland left review comments
encukou encukou approved these changes
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL