gh-116622: Android logging fixes - #122698
Conversation
Sorry, something went wrong.
freakboy3742
left a comment
There was a problem hiding this comment.
These changes all make sense to me; but there's a hypothesis test that is currently failing. I want to understand what's going on there before I formally approve/merge.
Sorry, something went wrong.
freakboy3742
left a comment
There was a problem hiding this comment.
Looks like the hypothesis failure is due to #122686, so I guess that makes this good to go!
Sorry, something went wrong.
|
Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
Modifies the handling of stdout/stderr redirection on Android to accomodate the rate and buffer size limits imposed by Android's logging infrastructure. (cherry picked from commit b0c48b8) Co-authored-by: Malcolm Smith <smith@chaquo.com>
|
GH-122719 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Modifies the handling of stdout/stderr redirection on Android to accomodate the rate and buffer size limits imposed by Android's logging infrastructure.
|
Hello! For next time, please could you update your blurb CLI? Thanks! https://discuss.python.org/t/new-blurb-1-2-please-upgrade/59159 |
Sorry, something went wrong.
Modifies the handling of stdout/stderr redirection on Android to accomodate the rate and buffer size limits imposed by Android's logging infrastructure.
This PR fixes several issues with Android's redirection of stdout and stderr to the Logcat, which was added in #118063:
The buffering behavior of TextIOWrapper was changed in #119507, which broke the technique we were previously using to stay within Logcat's line length limit. Since this behavior is not part of TextIOWrapper's public API, it's safer to bypass it completely and do the buffering ourselves.
When running in --verbose3 mode, I noticed that failure logs of large test modules like test_pathlib were truncated because they were being written faster than the test script could consume them. Fixed by adding a rate limit using the token bucket algorithm.
The Android stdout and stderr tests themselves failed in --verbose3 mode because stdout and stderr were captured by a StringIO. Fixed by detecting this mode and using some temporary streams with the same properties.