Repository navigation
gh-99631: Add custom loads and dumps support for the shelve module - #118065
picnixz merged 75 commits into
Conversation
Sorry, something went wrong.
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
encukou
left a comment
There was a problem hiding this comment.
BsdDbShelf still uses pickle.Unpickler directly to walk the keys.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. |
Sorry, something went wrong.
Co-authored-by: Petr Viktorin <encukou@gmail.com>
| @@ -160,18 +181,20 @@ Restrictions | |||
| modules. The *dict* object passed to the constructor must support those | |||
| methods. This is generally accomplished by calling one of | |||
| :func:`!bsddb.hashopen`, :func:`!bsddb.btopen` or :func:`!bsddb.rnopen`. The | |||
There was a problem hiding this comment.
By the way, we also need to update this sentence (from bsddb to berkeleydb). bsddb is deprecated according to https://www.jcea.es/programacion/pybsddb.htm.
Sorry, something went wrong.
There was a problem hiding this comment.
It looks like the change would be bigger: it’s a new module (although the docs are not very clear) with maybe a new API.
Updating or deprecating this should be discussed in its own ticket 🙂
Sorry, something went wrong.
There was a problem hiding this comment.
Yes, I agree on it. It would be better to open a new ticket to discuss this issue.
Sorry, something went wrong.
There was a problem hiding this comment.
... or consider instead opening topic on Discourse; this may need a larger audience than what you'd get on the bug tracker.
Sorry, something went wrong.
There was a problem hiding this comment.
Some few nitpicks that I thought of. Some should be addressed (3.15 -> next + self.subTest(proto=5)`, while others are purely cosmetics.
I'll let a core dev check other stuff (
This core dev is now me.
Sorry, something went wrong.
modified: Doc/library/shelve.rst
…t_missing_custom_serializer
picnixz
left a comment
There was a problem hiding this comment.
Almost done!
Sorry, something went wrong.
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
Oof, I forgot to merge main. Well, I don't think something for shelve changed in between and there were no conflicts, so it should be fine. Thanks for waiting! |
Sorry, something went wrong.
…e` module (python#118065) Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
…e` module (python#118065) Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Thanks for the merge! |
Sorry, something went wrong.
…e` module (python#118065) Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
…e` module (python#118065) Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
📚 Documentation preview 📚: https://cpython-previews--118065.org.readthedocs.build/