| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Could you add docs and tests? |
Sorry, something went wrong.
|
Do we need to specify the pickler and unpickler classes or just dumps() and loads() functions? |
Sorry, something went wrong.
|
I'd also go fordumps and loads instead of pickler/unpickler classes. With a proper definition (e.g. takes a Python object and returns bytes) I think that should make it much more simpler (it is also similar how other pickle-related APIs work outside of the stdlib) |
Sorry, something went wrong.
|
Doc and test have been added. @merwok The pickler and unpickler classes have been replaced with dumps() and load() functions. @isidentical @serhiy-storchaka |
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks a lot for your efforts @furkanonder, I have a few minor suggestions but this already looks great!
Sorry, something went wrong.
✅ Deploy Preview for python-cpython-preview canceled.
|
Sorry, something went wrong.
|
Should we require the serializer to accept the pickle protocol? It does not make sense for other than pickle formats. What happens if only serializer or only deserializer are passed? |
Sorry, something went wrong.
elif (serializer is None and deserializer is not None) or (deserializer is None and serializer is not None):
raise ShelveError("Serializer and deserializer must be defined together.")In this case, shelve raises an error. |
Sorry, something went wrong.
|
This seems to have been forgotten over end-of-year break in 2022. Do you want to revive it? The BsdDbShelf class needs to be updated as well; its extra functions should use deserializer rather than Unpickler |
Sorry, something went wrong.
|
I accidentally deleted my forked repository, so I can't update my old PRs. So I opened a new PR. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.