FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.5] bpo-34656: Avoid relying on signed overflow in _pickle memos (GH-9261) by vstinner · Pull Request #11869 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.5] bpo-34656: Avoid relying on signed overflow in _pickle memos (GH-9261) - #11869

Merged
larryhastings merged 3 commits into
python:3.5from
vstinner:pickle_load35
Feb 26, 2019
ConversationCommits (3)ChecksFiles changed
Merged

[3.5] bpo-34656: Avoid relying on signed overflow in _pickle memos (GH-9261)#11869
larryhastings merged 3 commits into
python:3.5from
vstinner:pickle_load35

Conversation

vstinner commented Feb 15, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

(cherry picked from commit a4ae828)

https://bugs.python.org/issue34656

vstinner commented Feb 15, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member Author

Oh, FTP tests are failing on Travis CI :-( I should backport this fix:

commit c11b3b19a5b022c6c229043d37f9a9fd06f22500
Author: Victor Stinner <vstinner@redhat.com>
Date:   Wed Dec 5 01:58:31 2018 +0100

    [bpo-35411](https://bugs.python.org/issue35411): Skip test_urllib2net FTP tests on Travis CI (GH-10907)
    
    On Travis CI, FTP tests of test_urllib2net randomly fail with "425
    Security: Bad IP connecting".
    
    test.pythoninfo now also logs TRAVIS environment variable.

vstinner commented Feb 15, 2019

Copy link
Copy Markdown
Member Author

Oh, FTP tests are failing on Travis CI :-( I should backport this fix:

Done: I created PR #11874.

vstinner mentioned this pull request Feb 15, 2019
Merged

vstinner commented Feb 25, 2019

Copy link
Copy Markdown
Member Author

@larryhastings "ftplib.error_temp: 425 Security: Bad IP connecting." bites again, you need a new merge to get my FTP fix.

bedevere-bot commented Feb 26, 2019

Copy link
Copy Markdown

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!

larryhastings commented Feb 26, 2019

Copy link
Copy Markdown
Contributor

Thanks for the backported fix! It does my heart good to see pickle avoiding integer overflows.

larryhastings merged commit ef33dd6 into python:3.5 Feb 26, 2019
vstinner deleted the pickle_load35 branch April 29, 2019 14:00
httpsgithubcomxcainiao mannequin mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL