Repository navigation
[3.5] bpo-35411: Skip test_urllib2net FTP tests on Travis CI (GH-10907) - #11874
Merged
larryhastings merged 2 commits intoFeb 25, 2019
Merged
larryhastings merged 2 commits into
larryhastings merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@larryhastings, @ned-deily or @ambv: Can you please merge this fix to unblock PR #11869 security fix? |
Sorry, something went wrong.
eamanu
approved these changes
Feb 15, 2019
eamanu
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
larryhastings
approved these changes
Feb 25, 2019
larryhastings
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Good, Travis CI succeeded ;-) |
Sorry, something went wrong.
Copy link
Copy Markdown
|
@larryhastings: Please replace # with GH- in the commit message next time. Thanks! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks for the fix! Now I can merge the other stuff. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Travis CI, FTP tests of test_urllib2net randomly fail with "425
Security: Bad IP connecting".
(cherry picked from commit c11b3b1)
https://bugs.python.org/issue35411