| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Co-authored-by: Eryk Sun <eryksun@gmail.com>
|
@zooba, I added the test Eryk requested. |
Sorry, something went wrong.
|
You already have two extremely competent reviewers for this PR: Eryk and Steve. Why are you keeping pinging other core devs? This only creates unneeded noise; please stop it. |
Sorry, something went wrong.
|
OK, but I'm not sure what Steve is waiting for. I thought we were done here. Could you react with eyes if you saw this? |
Sorry, something went wrong.
|
Mostly I was waiting for enough free time to give it a proper review - while I get work time to work on Python, it's not strictly my job, so I can't always prioritise reviews over other things. This looks good now. Since we need an additional change for 3.12, we'll need a manual backport for that |
Sorry, something went wrong.
|
Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
…r other cases (pythonGH-118755) (cherry picked from commit b641825) Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
|
Sorry, @nineteendo and @zooba, I could not cleanly backport this to 3.12 due to a conflict. cherry_picker b64182550f73e556344bd754d32e3be5d22a74e1 3.12 |
Sorry, something went wrong.
|
GH-119360 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
…r other cases (pythonGH-118755)
|
GH-119381 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
|
GH-119381 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
|
Note that it's not a full backport, as the C implementation of ntpath.isjunction() & ntpath.lexists() isn't included yet to minimise the risk of changed behaviour. We can consider backporting them later once we're more confident. |
Sorry, something went wrong.
|
GH-119420 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
|
GH-119420 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
…r other cases (pythonGH-118755)
|
Do you guys realize this breaks using path as a kwarg? You may want to update the docs. os.path.exists(path=".") TypeError: nt._path_exists() takes no keyword arguments |
Sorry, something went wrong.
|
@zooba, should this be fixed? diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index f02b6d1779827f..2a65752d9431fe 100644
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -5385,7 +5385,6 @@ _testFileType(path_t *path, int testedType)
os._path_exists -> bool
path: path_t(allow_fd=True, suppress_value_error=True)
- /
Test whether a path exists. Returns False for broken symbolic links.
@@ -5403,7 +5402,6 @@ os__path_exists_impl(PyObject *module, path_t *path)
os._path_lexists -> bool
path: path_t(allow_fd=True, suppress_value_error=True)
- /
Test whether a path exists. Returns True for broken symbolic links. |
Sorry, something went wrong.
|
@sobolevn is this a problem? |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.