FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.12] gh-118507 : Fix `ntpath.isfile` for pipes. by nineteendo · Pull Request #119381 · python/cpython · GitHub

/ cpython Public

[3.12] gh-118507 : Fix ntpath.isfile for pipes. - #119381

Merged
zooba merged 5 commits into
python:3.12from
nineteendo:backport-b641825-3.12
May 22, 2024
ConversationCommits (5)ChecksFiles changed
Merged

[3.12] gh-118507 : Fix ntpath.isfile for pipes.#119381
zooba merged 5 commits into
python:3.12from
nineteendo:backport-b641825-3.12

Conversation

nineteendo commented May 22, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This was referenced May 22, 2024
Closed
Merged

nineteendo commented May 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I think I didn't include unrelated changes. Is it fine to use the C version for ntpath.isjunction() and ntpath.lexists()? (We did so for 3.13 too) Otherwise I'll revert that change.

nineteendo marked this pull request as ready for review May 22, 2024 07:23
nineteendo changed the title [3.12] gh-118507 : Refactor nt._path_is* (GH-118755) [3.12] gh-118507 : Refactor nt._path_is* to improve applicability for other cases (GH-118755) May 22, 2024

zooba commented May 22, 2024

Copy link
Copy Markdown
Member

Is it fine to use the C version for ntpath.isjunction() and ntpath.lexists()?

Let's revert those, just to minimise the risk of changed behaviour. We can consider backporting them later once we're more confident.

zooba self-assigned this May 22, 2024

nineteendo commented May 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Done, I also removed the C implementation for these functions to not give anyone ideas...
I can make a draft pull request afterwards to make it clear the issue can't be closed yet.

nineteendo changed the title [3.12] gh-118507 : Refactor nt._path_is* to improve applicability for other cases (GH-118755) [3.12] gh-118507 : Fix ntpath.isfile for pipes. May 22, 2024
zooba merged commit 874a4f7 into python:3.12 May 22, 2024

zooba commented May 22, 2024

Copy link
Copy Markdown
Member

A draft pull request is a good idea.

nineteendo deleted the backport-b641825-3.12 branch May 22, 2024 15:01
nineteendo mentioned this pull request Oct 3, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

zooba

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL