FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-115119: Fall back to bundled libmpdec if system libmpdec is not found by erlend-aasland · Pull Request #119196 · python/cpython · GitHub

/ cpython Public

gh-115119: Fall back to bundled libmpdec if system libmpdec is not found - #119196

Merged
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:libmpdec-fallback
May 20, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-115119: Fall back to bundled libmpdec if system libmpdec is not found#119196
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:libmpdec-fallback

Conversation

erlend-aasland commented May 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor 
$ brew unlink libmpdec
$ ./configure --with-system-libmpdec | grep -E "(decimal|mpdec)"
checking for --with-system-libmpdec... yes
checking for libmpdec >= 2.5.0... no
configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
checking for --with-decimal-contextvar... yes
checking for decimal libmpdec machine... universal
checking for stdlib extension module _decimal... yes
$ grep 'DECIMAL_.*FLAGS' Makefile
MODULE__DECIMAL_CFLAGS=-I$(srcdir)/Modules/_decimal/libmpdec -DUNIVERSAL=1
MODULE__DECIMAL_LDFLAGS=-lm $(LIBMPDEC_A)

$ ./configure | grep -E "(decimal|mpdec)"
checking for --with-system-libmpdec... yes
checking for libmpdec >= 2.5.0... no
configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
checking for --with-decimal-contextvar... yes
checking for decimal libmpdec machine... universal
checking for stdlib extension module _decimal... yes
$ grep 'DECIMAL_.*FLAGS' Makefile
MODULE__DECIMAL_CFLAGS=-I$(srcdir)/Modules/_decimal/libmpdec -DUNIVERSAL=1
MODULE__DECIMAL_LDFLAGS=-lm $(LIBMPDEC_A)

$ ./configure --without-system-libmpdec | grep -E "(decimal|mpdec)"
checking for --with-system-libmpdec... no
configure: WARNING: the bundled copy of libmpdecimal is scheduled for removal in Python 3.15; consider using a system installed mpdecimal library.
checking for --with-decimal-contextvar... yes
checking for decimal libmpdec machine... universal
checking for stdlib extension module _decimal... yes
$ grep ‘DECIMAL_.*FLAGS’ Makefile
MODULE__DECIMAL_CFLAGS=-I$(srcdir)/Modules/_decimal/libmpdec -DUNIVERSAL=1
MODULE__DECIMAL_LDFLAGS=-lm $(LIBMPDEC_A)

$ brew link libmpdec
$ ./configure --with-system-libmpdec | grep -E "(decimal|mpdec)"
checking for --with-system-libmpdec... yes
checking for libmpdec >= 2.5.0... yes
checking for --with-decimal-contextvar... yes
checking for stdlib extension module _decimal... yes
$ grep ‘DECIMAL_.*FLAGS’ Makefile
MODULE__DECIMAL_CFLAGS=-I/opt/homebrew/Cellar/mpdecimal/4.0.0/include
MODULE__DECIMAL_LDFLAGS=-L/opt/homebrew/Cellar/mpdecimal/4.0.0/lib -lmpdec -lm

erlend-aasland requested a review from corona10 as a code owner May 20, 2024 02:55
erlend-aasland added the needs backport to 3.13 bugs and security fixes label May 20, 2024
bedevere-app Bot mentioned this pull request May 20, 2024
Closed
15 tasks
erlend-aasland requested review from ned-deily and zware May 20, 2024 02:56
This was referenced May 20, 2024
Merged
Closed
erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 20, 2024

bedevere-bot commented May 20, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit c537d8b 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 20, 2024
ned-deily approved these changes May 20, 2024
View reviewed changes

ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

erlend-aasland commented May 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks for the review, Ned! FTR, the buildbot failures all seem unrelated1

Footnotes

  1. buildbot/PPC64LE Fedora Stable Refleaks PR is another regression I introduced in sqlite3; PR is already up merged 😄 ↩

erlend-aasland commented May 20, 2024

Copy link
Copy Markdown
Contributor Author

I'll wait for Zach to chime in before landing.

vstinner commented May 20, 2024

Copy link
Copy Markdown
Member

cc @hroncok who had issues with this issue.

erlend-aasland commented May 20, 2024

Copy link
Copy Markdown
Contributor Author

Merging, as per Ned's comment on Discord.

erlend-aasland merged commit 642b25b into python:main May 20, 2024
erlend-aasland deleted the libmpdec-fallback branch May 20, 2024 14:58

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
pythongh-115119: Fall back to bundled libmpdec if system libmpdec is …
f007dae 
…not found (pythonGH-119196)

(cherry picked from commit 642b25b)

Co-authored-by: Erlend E. Aasland <erlend@python.org>

bedevere-app Bot commented May 20, 2024

Copy link
Copy Markdown

GH-119217 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 20, 2024
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request May 20, 2024
Amend NEWS category for pythongh-119196
7d0c79d
erlend-aasland added a commit that referenced this pull request May 20, 2024
Amend NEWS category for gh-119196 (#119218)
6f7dd0a
erlend-aasland added a commit that referenced this pull request May 20, 2024
[3.13] gh-115119: Fall back to bundled libmpdec if system libmpdec is…
e370b64 
… not found (GH-119196) (#119217)

(cherry picked from commit 642b25b)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-115119: Fall back to bundled libmpdec if system libmpdec is …
b1d0a78 
…not found (python#119196)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Amend NEWS category for pythongh-119196 (python#119218)
15aef31
hughsw mentioned this pull request Aug 14, 2024
Merged
skirpichev mentioned this pull request Oct 12, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ned-deily ned-deily approved these changes
corona10 Awaiting requested review from corona10 corona10 is a code owner
zware Awaiting requested review from zware

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL