gh-93691: fix too broad source locations of with-statement instructions - #120125
Merged
iritkatriel merged 3 commits intoJun 7, 2024
Merged
gh-93691: fix too broad source locations of with-statement instructions#120125iritkatriel merged 3 commits into
iritkatriel merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
carljm
approved these changes
Jun 6, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Copy link
Copy Markdown
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 2, 2024
…ructions (pythonGH-120125) (cherry picked from commit eca3f77) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-123604 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 2, 2024
…ructions (pythonGH-120125) (cherry picked from commit eca3f77) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-123605 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously an exception from the __init__, __enter__ and __exit__ would give the whole with-statement, with the body, as the location. Now it pinpoints which context manager failed.