[3.13] gh-98442: fix locations of with statement's cleanup instructions (GH-120763) - #120786
Merged
iritkatriel merged 4 commits intoSep 2, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
pythonGH-120763) (cherry picked from commit 55596ae) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com> pythongh-98442: fix location of with statement's cleanup instructions
iritkatriel
approved these changes
Jun 20, 2024
iritkatriel
enabled auto-merge (squash)
June 20, 2024 08:33
Copy link
Copy Markdown
Member
|
@iritkatriel The test failures seem real, can you take a look? (Doesn't have to be before rc2, this is probably fine to push to 3.13.1?) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Thanks. I think it's because I didn't backport #120125. I'll try now. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 55596ae)
Co-authored-by: Irit Katriel 1055913+iritkatriel@users.noreply.github.com
gh-98442: fix location of with statement's cleanup instructions