FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-98442: fix locations of with statement's cleanup instructions by iritkatriel · Pull Request #120763 · python/cpython · GitHub

/ cpython Public

gh-98442: fix locations of with statement's cleanup instructions - #120763

Merged
iritkatriel merged 1 commit into
python:mainfrom
iritkatriel:gh-98442
Jun 20, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-98442: fix locations of with statement's cleanup instructions#120763
iritkatriel merged 1 commit into
python:mainfrom
iritkatriel:gh-98442

Conversation

iritkatriel commented Jun 19, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

iritkatriel requested a review from markshannon as a code owner June 19, 2024 21:04
bedevere-app Bot mentioned this pull request Jun 19, 2024
Closed
iritkatriel added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jun 19, 2024
iritkatriel requested a review from carljm June 19, 2024 21:04
JelleZijlstra reviewed Jun 20, 2024
View reviewed changes
Comment thread Lib/test/test_compile.py

# Expect three load None instructions for the no-exception __exit__ call,
# and one RETURN_VALUE.
# They should all have the locations of the context manager ('xyz').

JelleZijlstra Jun 20, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why doesn't the RETURN_VALUE have the location of the return statement?

iritkatriel Jun 20, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The calculation of the value has that location. The return itself occurs after the exit, so it gets the location of the exit (the last instruction executed before the return).

iritkatriel merged commit 55596ae into python:main Jun 20, 2024

miss-islington-app Bot commented Jun 20, 2024

Copy link
Copy Markdown

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2024
pythongh-98442: fix locations of with statement's cleanup instructions (
e8247d7 
pythonGH-120763)

(cherry picked from commit 55596ae)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
pythongh-98442: fix location of with statement's cleanup instructions

bedevere-app Bot commented Jun 20, 2024

Copy link
Copy Markdown

GH-120786 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 20, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2024
pythongh-98442: fix locations of with statement's cleanup instructions (
0e9c759 
pythonGH-120763)

(cherry picked from commit 55596ae)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
pythongh-98442: fix location of with statement's cleanup instructions

bedevere-app Bot commented Jun 20, 2024

Copy link
Copy Markdown

GH-120787 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jun 20, 2024
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
pythongh-98442: fix locations of with statement's cleanup instructions (
1dc7a0f 
python#120763)

pythongh-98442: fix location of with statement's cleanup instructions
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
pythongh-98442: fix locations of with statement's cleanup instructions (
c7198e7 
python#120763)

pythongh-98442: fix location of with statement's cleanup instructions
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-98442: fix locations of with statement's cleanup instructions (
915c07e 
python#120763)

pythongh-98442: fix location of with statement's cleanup instructions
iritkatriel added a commit that referenced this pull request Sep 2, 2024
[3.13] gh-98442: fix locations of with statement's cleanup instructio…
80e0326 
…ns (GH-120763) (#120786)

gh-98442: fix locations of with statement's cleanup instructions (GH-120763)
(cherry picked from commit 55596ae)


gh-98442: fix location of with statement's cleanup instructions

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
iritkatriel added a commit that referenced this pull request Sep 15, 2024
[3.12] gh-98442: fix locations of with statement's cleanup instructio…
ffde4cd 
…ns (GH-120763) (#120787)

gh-98442: fix locations of with statement's cleanup instructions (GH-120763)
(cherry picked from commit 55596ae)


gh-98442: fix location of with statement's cleanup instructions

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner
carljm Awaiting requested review from carljm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Source location of return instruction in a with block is incorrect

2 participants

Back | FazBrowse Home | New Git URL