gh-120389: Add PyLong_FromInt64() and PyLong_AsInt64() by vstinner · Pull Request #120390 · python/cpython · GitHub

Add new functions to convert C <stdint.h> numbers from/to Python int:

PyLong_FromInt32()
PyLong_FromUInt32()
PyLong_FromInt64()
PyLong_FromUInt64()
PyLong_AsInt32()
PyLong_AsUInt32()
PyLong_AsInt64()
PyLong_AsUInt64()

Issue: [C API] Add PyLong_FromInt64() and PyLong_ToInt64() #120389

Draft PR to see how #120389 can be implemented. I will complete the PR once we agree on #120389 design.

Add new functions to convert C <stdint.h> numbers from/to Python int: * PyLong_FromInt32() * PyLong_FromUInt32() * PyLong_FromInt64() * PyLong_FromUInt64() * PyLong_ToInt32() * PyLong_ToUInt32() * PyLong_ToInt64() * PyLong_ToUInt64()

This PR is now ready for review.

PyLong_ToUInt32() and PyLong_ToUInt64() can now use the __index__() method if the object has the method.

LGTM. Would like it if we don't have to have docs like "like this other function", but if that's the best we can do then I'll survive.

Would like it if we don't have to have docs like "like this other function", but if that's the best we can do then I'll survive.

I grouped functions by pairs in the documentation.

The formatting in the docs preview looks good 👍

Calling __index__ can release the GIL and make values saved in C variables (borrowed references, the size of a list, etc) invalid. Existing code can rely on atomicity of PyLong_AsUnsignedLong(), so calling __index__ in it is an unsafe change.

Existing code can rely on atomicity of PyLong_AsUnsignedLong(), so calling index in it is an unsafe change.

This PR doesn't change PyLong_AsUnsignedLong(). Are you referring to code replacing PyLong_AsUnsignedLong() with one of these functions?

Calling index can release the GIL and make values saved in C variables (borrowed references, the size of a list, etc) invalid.

For me, it's strange that signed and unsigned integers are treated diffferently. I would like to treat them the same.

The GIL issue can be mentioned in the doc? For example:

This function can release the GIL temporarily indirectly while calling an __index__() method.

I created capi-workgroup/decisions#32 "Add PyLong_FromInt64() and PyLong_ToInt64()" in the C API WG Decisions project.

LGTM.

This is not needed. You can define them in the Python code as INT32_MAX = 2**31 - 1 etc.

I prefer to reuse <limits.h> C constants to avoid any typo.

@serhiy-storchaka @zooba @encukou: Would you mind to review the updated PR? I updated the PR to the API approved the C API WG. It now uses the __index__() method and functions are called "As" (instead of "To").

LGTM, but check_long_asunsignedint is now superseded by check_long_asint.

Reuse check_long_asint().

but check_long_asunsignedint is now superseded by check_long_asint.

I removed check_long_asunsignedint() to reuse check_long_asint().

Co-authored-by: Petr Viktorin <encukou@gmail.com>

bedevere-app Bot mentioned this pull request Jun 12, 2024

[C API] Add PyLong_FromInt64() and PyLong_ToInt64() #120389

Closed

vstinner added the skip news label Jun 12, 2024

vstinner changed the title gh-120389: Add PyLong_FromInt64() and PyLong_AsInt64() gh-120389: Add PyLong_FromInt64() and PyLong_ToInt64() Jun 17, 2024

vstinner force-pushed the stdint branch 4 times, most recently from 93e27a1 to 684360e Compare June 19, 2024 15:29

vstinner force-pushed the stdint branch from 684360e to 3e50341 Compare June 19, 2024 15:47

Add uint32_t to Doc/conf.py

7c7b976

vstinner marked this pull request as ready for review June 19, 2024 16:36

vstinner requested review from a team and encukou as code owners June 19, 2024 16:36

bedevere-app Bot added the awaiting core review label Jun 19, 2024

vstinner mentioned this pull request Jun 19, 2024

Avoid C-specific Types capi-workgroup/api-evolution#10

Closed

zooba reviewed Jun 19, 2024

View reviewed changes

Comment thread Objects/longobject.c Outdated

Use PyLong_AsNativeBytes()

c239d18

PyLong_ToUInt32() and PyLong_ToUInt64() can now use the __index__() method if the object has the method.

zooba reviewed Jun 20, 2024

View reviewed changes

Comment thread Doc/c-api/long.rst Outdated

zooba approved these changes Jun 20, 2024

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 20, 2024

Group documentations

1186043

vstinner mentioned this pull request Jun 24, 2024

Add PyLong_FromInt64() and PyLong_AsInt64() capi-workgroup/decisions#32

Closed

vstinner mentioned this pull request Jul 4, 2024

The C-API for Python to C integer conversion is, to be frank, a mess. #102471

Open

serhiy-storchaka approved these changes Jul 22, 2024

View reviewed changes

serhiy-storchaka mentioned this pull request Jul 22, 2024

Refactor test_capi.test_long #122113

Merged

picnixz reviewed Jul 22, 2024

View reviewed changes

Comment thread Doc/c-api/long.rst Outdated

Comment thread Doc/c-api/long.rst Outdated

Comment thread Objects/longobject.c Outdated

Comment thread Objects/longobject.c

vstinner added 5 commits August 27, 2024 14:45

Replace "To" with "As"

c2150c1

Merge branch 'main' into stdint

050f415

Use Py_ASNATIVEBYTES_ALLOW_INDEX

830d250

stable_abi: replace "To" with "As"

42b9902

Address Bénédikt's review

0199a80

picnixz approved these changes Aug 27, 2024

View reviewed changes

vstinner changed the title gh-120389: Add PyLong_FromInt64() and PyLong_ToInt64() gh-120389: Add PyLong_FromInt64() and PyLong_AsInt64() Aug 27, 2024

serhiy-storchaka approved these changes Aug 27, 2024

View reviewed changes

Comment thread Lib/test/test_capi/test_long.py Outdated

Remove check_long_asunsignedint() in tests

71748a7

Reuse check_long_asint().

serhiy-storchaka approved these changes Aug 28, 2024

View reviewed changes

encukou approved these changes Aug 28, 2024

View reviewed changes

Comment thread Doc/c-api/long.rst Outdated

Comment thread Doc/c-api/long.rst Outdated

vstinner and others added 2 commits August 28, 2024 11:51

Update Doc/c-api/long.rst

dd2194e

Co-authored-by: Petr Viktorin <encukou@gmail.com>

Update Doc/c-api/long.rst

7070514

Co-authored-by: Petr Viktorin <encukou@gmail.com>

vstinner enabled auto-merge (squash) August 28, 2024 09:52

vstinner merged commit 4c6dca8 into python:main Aug 28, 2024

vstinner deleted the stdint branch August 28, 2024 10:16

bedevere-app Bot removed the awaiting merge label Aug 28, 2024

KRRT7 mentioned this pull request May 28, 2026

Widen specialized int fast paths to full int64 range #150424

Open

+                  PyModule_AddObject(m, "INT32_MIN", PyLong_FromInt32(INT32_MIN));
+                  PyModule_AddObject(m, "INT32_MAX", PyLong_FromInt32(INT32_MAX));
+                  PyModule_AddObject(m, "UINT32_MAX", PyLong_FromUInt32(UINT32_MAX));
+                  PyModule_AddObject(m, "INT64_MIN", PyLong_FromInt64(INT64_MIN));
+                  PyModule_AddObject(m, "INT64_MAX", PyLong_FromInt64(INT64_MAX));
+                  PyModule_AddObject(m, "UINT64_MAX", PyLong_FromUInt64(UINT64_MAX));

gh-120389: Add PyLong_FromInt64() and PyLong_AsInt64() by vstinner · Pull Request #120390 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-120389: Add PyLong_FromInt64() and PyLong_AsInt64() - #120390

gh-120389: Add PyLong_FromInt64() and PyLong_AsInt64()#120390vstinner merged 12 commits intopython:mainpython/cpython:mainfrom vstinner:stdintvstinner/cpython:stdintCopy head branch name to clipboard

Conversation

vstinner commented Jun 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner commented Jun 12, 2024

Uh oh!

vstinner commented Jun 19, 2024

Uh oh!

Uh oh!

Uh oh!

zooba left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner commented Jun 20, 2024

Uh oh!

zooba commented Jun 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka commented Jun 24, 2024

Uh oh!

vstinner commented Jun 24, 2024

Uh oh!

vstinner commented Jun 24, 2024

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

serhiy-storchaka Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

vstinner Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner commented Aug 27, 2024

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vstinner commented Aug 28, 2024

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gh-120389: Add PyLong_FromInt64() and PyLong_AsInt64()#120390
vstinner merged 12 commits into
python:mainfrom
vstinner:stdint

vstinner commented Jun 12, 2024 •
edited
Loading

zooba commented Jun 20, 2024 •
edited
Loading