FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Refactor test_capi.test_long by serhiy-storchaka · Pull Request #122113 · python/cpython · GitHub

/ cpython Public

Refactor test_capi.test_long - #122113

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:test-capi-long
Jul 22, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Refactor test_capi.test_long#122113
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:test-capi-long

Conversation

serhiy-storchaka commented Jul 22, 2024

Copy link
Copy Markdown
Member

Share common code for tests for PyLong_As*() functions.

Based on test changes in #120390. The same helper is used in tests for all signed and unsigned integer types. negative_value_error is now an exception class, not a boolean.

Refactor test_capi.test_long
53b9382 
Share common code for tests for PyLong_As*() functions.

Co-authored-by: Victor Stinner <vstinner@python.org>
serhiy-storchaka added tests Tests in the Lib/test dir skip issue skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 22, 2024
serhiy-storchaka mentioned this pull request Jul 22, 2024
Merged
vstinner approved these changes Jul 22, 2024
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

serhiy-storchaka merged commit 69f2dc5 into python:main Jul 22, 2024

miss-islington-app Bot commented Jul 22, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2024
Refactor test_capi.test_long (pythonGH-122113)
e4d3e4a 
Share common code for tests for PyLong_As*() functions.
(cherry picked from commit 69f2dc5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>

bedevere-app Bot commented Jul 22, 2024

Copy link
Copy Markdown

GH-122137 is a backport of this pull request to the 3.13 branch.

miss-islington-app Bot commented Jul 22, 2024

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 69f2dc5c06e62b4a9eb4da8f0cd456cc09b998ed 3.12

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 22, 2024

serhiy-storchaka commented Jul 22, 2024

Copy link
Copy Markdown
Member Author

Thank you, Victor.

serhiy-storchaka added a commit that referenced this pull request Jul 23, 2024
[3.13] Refactor test_capi.test_long (GH-122113) (GH-122137)
4892cc0 
Share common code for tests for PyLong_As*() functions.
(cherry picked from commit 69f2dc5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 23, 2024
[3.12] Refactor test_capi.test_long (pythonGH-122113)
bf2822f 
Share common code for tests for PyLong_As*() functions.
(cherry picked from commit 69f2dc5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>

bedevere-app Bot commented Jul 23, 2024

Copy link
Copy Markdown

GH-122151 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 23, 2024
serhiy-storchaka added a commit that referenced this pull request Jul 23, 2024
[3.12] Refactor test_capi.test_long (GH-122113) (GH-122151)
b24ca6a 
Share common code for tests for PyLong_As*() functions.
(cherry picked from commit 69f2dc5)

Co-authored-by: Victor Stinner <vstinner@python.org>
serhiy-storchaka deleted the test-capi-long branch July 1, 2026 16:47
serhiy-storchaka removed their assignment Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL