FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-117398: Use the correct module loader for iOS in datetime CAPI test. by freakboy3742 · Pull Request #120477 · python/cpython · GitHub

/ cpython Public

gh-117398: Use the correct module loader for iOS in datetime CAPI test. - #120477

Merged
freakboy3742 merged 1 commit into
python:mainfrom
freakboy3742:datetime-capitest
Jun 15, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-117398: Use the correct module loader for iOS in datetime CAPI test.#120477
freakboy3742 merged 1 commit into
python:mainfrom
freakboy3742:datetime-capitest

Conversation

freakboy3742 commented Jun 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

#119604 added a CAPI test for subinterpreters in the datetime tests; however, the test uses the ExtensionFileLoader to load _testcapi. iOS requires the use of the AppleFrameworkLoader.

The buildbot validation will fail because of #120476; however, with this PR, test_datetime no longer fails.

freakboy3742 added tests Tests in the Lib/test dir skip news OS-ios labels Jun 14, 2024
bedevere-app Bot mentioned this pull request Jun 14, 2024
Closed

freakboy3742 commented Jun 14, 2024

Copy link
Copy Markdown
Contributor Author

!buildbot iOS

bedevere-bot commented Jun 14, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 03293ac 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

freakboy3742 mentioned this pull request Jun 14, 2024
Merged
ericsnowcurrently approved these changes Jun 14, 2024
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ericsnowcurrently commented Jun 14, 2024

Copy link
Copy Markdown
Member

Thanks for fixing this. Sorry I didn't catch it yesterday! FWIW, I like your solution taking advantage of the f-string. 😄

freakboy3742 merged commit 5c58e72 into python:main Jun 15, 2024
freakboy3742 deleted the datetime-capitest branch June 15, 2024 00:05
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
pythongh-117398: Use the correct module loader for iOS in datetime CA…
b27cc03 
…PI test. (python#120477)

Use the correct loader for iOS.
neonene mentioned this pull request Jul 10, 2024
Merged

bedevere-app Bot commented Jul 10, 2024

Copy link
Copy Markdown

GH-121561 is a backport of this pull request to the 3.13 branch.

freakboy3742 pushed a commit that referenced this pull request Jul 10, 2024
[3.13] gh-117398: Use the correct module loader for iOS in datetime C…
c08a302 
…API test (GH-120477) (#121561)

Use the correct binary module loader for iOS.
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
pythongh-117398: Use the correct module loader for iOS in datetime CA…
81ee80f 
…PI test. (python#120477)

Use the correct loader for iOS.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-117398: Use the correct module loader for iOS in datetime CA…
baacac8 
…PI test. (python#120477)

Use the correct loader for iOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently ericsnowcurrently approved these changes
pganssle Awaiting requested review from pganssle pganssle is a code owner
abalkin Awaiting requested review from abalkin

Assignees

No one assigned

Labels

OS-ios skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL